Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove mobx #4131

Merged
merged 24 commits into from
Nov 12, 2024

fix: ci

1ef9d77
Select commit
Loading
Failed to load commit list.
Merged

refactor: remove mobx #4131

fix: ci
1ef9d77
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 7, 2024 in 0s

54.16% (-0.07%) compared to 926108b

View this Pull Request on Codecov

54.16% (-0.07%) compared to 926108b

Details

Codecov Report

Attention: Patch coverage is 66.54412% with 182 lines in your changes missing coverage. Please review.

Project coverage is 54.16%. Comparing base (926108b) to head (1ef9d77).

Files with missing lines Patch % Lines
...nsion-manager/src/browser/vsx-extension.service.ts 0.00% 29 Missing and 2 partials ⚠️
...-layout/src/browser/accordion/accordion.service.ts 63.49% 17 Missing and 6 partials ⚠️
...-next/src/browser/contribution/terminal.command.ts 0.00% 18 Missing and 5 partials ⚠️
...ackages/terminal-next/src/browser/terminal.view.ts 77.45% 19 Missing and 4 partials ⚠️
packages/quick-open/src/browser/quick-title-bar.ts 50.00% 10 Missing and 5 partials ⚠️
...s/terminal-next/src/browser/terminal.controller.ts 0.00% 10 Missing and 1 partial ⚠️
packages/comments/src/browser/comments.service.ts 33.33% 3 Missing and 5 partials ⚠️
...idget/inline-chat/inline-chat-editor.controller.ts 0.00% 6 Missing and 1 partial ⚠️
packages/comments/src/browser/comments-thread.ts 87.23% 5 Missing and 1 partial ⚠️
...ion/src/browser/vscode/api/main.thread.comments.ts 50.00% 4 Missing and 2 partials ⚠️
... and 11 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4131      +/-   ##
==========================================
- Coverage   54.23%   54.16%   -0.07%     
==========================================
  Files        1598     1598              
  Lines       97657    97625      -32     
  Branches    19984    19979       -5     
==========================================
- Hits        52961    52879      -82     
- Misses      37124    37167      +43     
- Partials     7572     7579       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov