Add Option for Inserting Delay between Key Press Events #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getint apparently gives `None` if the config value is missing instead of throwing a `KeyValue` exception, so it eventually ends up falling through the `InvalidConfigOption` path and wrongly reports an error
|
(while this was the approach that the original code use also) It feels like redundant duplication of code to repeat the delay code in Windows/Linux/Mac. May be a better idea to handle it in the layer above. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
On Pop_OS! 22.04, typing in Firefox often drops backspaces when undoing words (likely due to #1030). While it doesn't fix that issue, this is a suitable workaround in the mean time (there are also other input issues for other users on other OSes that are fixed by adding a delay between key presses).
Supersedes #1132 (see this comment).
Also keeps the same option name as the original PR so that anyone using the old PR can use this one without having to change anything.
Notable changes from the original PR
Also includes this change to delay when changing keymaps in Linux.
Adds
set_key_press_delayto Output. When not implemented it currently raises aNotImplementedError, although for some output interfaces it may be okay to just leave it as a stub.Tested on:
Pull Request Checklist