Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use database helpers from mariadb-operator/api #323

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Oct 2, 2023

The lib-common/modules/database is moved to mariadb-operator/api to remove a circular dependency.

@openshift-ci openshift-ci bot requested review from lewisdenny and stuggi October 2, 2023 11:10
@gibizer
Copy link
Contributor Author

gibizer commented Oct 2, 2023

/hold waiting for the deps

The lib-common/modules/database is moved to mariadb-operator/api to
remove a circular dependency.
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 5, 2023
@gibizer
Copy link
Contributor Author

gibizer commented Oct 5, 2023

/unhold

@openshift-ci openshift-ci bot merged commit e750197 into openstack-k8s-operators:main Oct 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants