Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin websockets library [zed] #673

Merged
merged 2 commits into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/tox.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,13 @@ jobs:
needs: build
steps:
- uses: actions/checkout@v1
- name: Free Disk Space (Ubuntu)
uses: jlumbroso/free-disk-space@main
with:
tool-cache: false
large-packages: false
docker-images: false
swap-storage: false
- name: Install dependencies
run: |
set -euxo pipefail
Expand Down Expand Up @@ -80,7 +87,7 @@ jobs:
juju crashdump -m $model -o logs/
- name: upload logs on failure
if: failure()
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: test-run-logs-and-crashdump
path: logs/
4 changes: 4 additions & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,7 @@ sphinx
sphinxcontrib-asyncio
# https://github.com/go-macaroon-bakery/py-macaroon-bakery/issues/94
macaroonbakery!=1.3.3

# NOTE(freyes): Set upper bound for websockets until libjuju is compatible with
# newer versions. See https://github.com/juju/python-libjuju/pull/1208
websockets<13.0.0
3 changes: 3 additions & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@

# https://github.com/go-macaroon-bakery/py-macaroon-bakery/issues/94
'macaroonbakery != 1.3.3',
# NOTE(freyes): Set upper bound for websockets until libjuju is compatible
# with newer versions. See https://github.com/juju/python-libjuju/pull/1208
'websockets<13.0.0',
]

tests_require = [
Expand Down
4 changes: 4 additions & 0 deletions test-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ keystoneauth1
oslo.config
python-novaclient
tenacity
# NOTE(freyes): Set upper bound for websockets until libjuju is compatible with
# newer versions. See https://github.com/juju/python-libjuju/pull/1208
websockets<13.0.0

# pinned until 3.0 regressions are handled: https://github.com/openstack-charmers/zaza/issues/545
juju<3.0
# https://github.com/go-macaroon-bakery/py-macaroon-bakery/issues/94
Expand Down