Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin dependencies for py36 compatibility [train backport] #637

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Pin dependencies for py36 compatibility [train backport] #637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2b67ea
Pin dependencies for py36 compatibility
freyes Dec 14, 2023
007b9db
Run CI on ubuntu-20.04
freyes Dec 14, 2023
776675b
Deny the use of libjuju 2.9.45 and 2.9.46
freyes Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tox.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:

jobs:
build:
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
strategy:
matrix:
python-version: [3.6, 3.7, 3.8, 3.9]
Expand Down
18 changes: 17 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
pyparsing<3.0.0 # pin for aodhclient which is held for py35
aiounittest
async_generator
juju<3.0
# 2.9.45.0 - https://github.com/juju/python-libjuju/pull/993
juju<3.0,!=2.9.45.0,!=2.9.46.0
kubernetes<18.0.0; python_version < '3.6' # pined, as juju uses kubernetes
juju_wait
PyYAML>=3.0
Expand Down Expand Up @@ -41,3 +42,18 @@ python-libmaas
# Documentation requirements
sphinx
sphinxcontrib-asyncio
# The following pinning is to keep zaza compatible with python 3.6
#
# protobuf dropped support for python-3.6 in v3.20.0[0], although it wasn't
# until 4.21.0 that it became truly incompatible. The pinning used is `<4.21.0`
#
# [0] https://github.com/protocolbuffers/protobuf/commit/301d315dc4674d1bc799446644e88eff0af1ac86
# [1] https://github.com/protocolbuffers/protobuf/issues/10076
protobuf<4.21.0

# macaroonbakery in v1.3.4 added a constraint of protobuf>=3.20.0[0] which makes it incompatible with python 3.6
# while v1.3.3 was released in a broken state[1]
#
# [0] https://github.com/go-macaroon-bakery/py-macaroon-bakery/commit/7f1fe6a2adb2f80db12bccfb81f629d66d106e03
# [1] https://github.com/go-macaroon-bakery/py-macaroon-bakery/pull/92
macaroonbakery < 1.3.3
17 changes: 16 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,26 @@

'hvac<0.7.0',
'jinja2',
'juju<3.0',
# 2.9.45.0 - https://github.com/juju/python-libjuju/pull/993
'juju<3.0,!=2.9.45,!=2.9.46',
'juju-wait',
'PyYAML',
'tenacity',
'python-libmaas',
# protobuf dropped support for python-3.6 in v3.20.0[0], although it wasn't
# until 4.21.0 that it became truly incompatible. The pinning used is
# `<4.21.0`
#
# [0] https://github.com/protocolbuffers/protobuf/commit/301d315dc4674d1bc799446644e88eff0af1ac86 # noqa
# [1] https://github.com/protocolbuffers/protobuf/issues/10076
'protobuf < 4.21.0',
# macaroonbakery in v1.3.4 added a constraint of protobuf>=3.20.0[0] which
# makes it incompatible with python 3.6 while v1.3.3 was released in a
# broken state[1]
#
# [0] https://github.com/go-macaroon-bakery/py-macaroon-bakery/commit/7f1fe6a2adb2f80db12bccfb81f629d66d106e03 # noqa
# [1] https://github.com/go-macaroon-bakery/py-macaroon-bakery/pull/92
'macaroonbakery < 1.3.3',
]

tests_require = [
Expand Down
Loading