Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin dependencies for py36 compatibility [wallaby backport] #634

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Pin dependencies for py36 compatibility [wallaby backport] #634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,19 @@ python-libmaas
# Documentation requirements
sphinx
sphinxcontrib-asyncio
# https://github.com/go-macaroon-bakery/py-macaroon-bakery/issues/94
macaroonbakery!=1.3.3
openstacksdk<=1.5.0; # Pin to a lower version of openstacksdk due to introduced libraries
# The following pinning is to keep zaza compatible with python 3.6
#
# protobuf dropped support for python-3.6 in v3.20.0[0], although it wasn't
# until 4.21.0 that it became truly incompatible. The pinning used is `<4.21.0`
#
# [0] https://github.com/protocolbuffers/protobuf/commit/301d315dc4674d1bc799446644e88eff0af1ac86
# [1] https://github.com/protocolbuffers/protobuf/issues/10076
protobuf<4.21.0

# macaroonbakery in v1.3.4 added a constraint of protobuf>=3.20.0[0] which makes it incompatible with python 3.6
# while v1.3.3 was released in a broken state[1]
#
# [0] https://github.com/go-macaroon-bakery/py-macaroon-bakery/commit/7f1fe6a2adb2f80db12bccfb81f629d66d106e03
# [1] https://github.com/go-macaroon-bakery/py-macaroon-bakery/pull/92
macaroonbakery < 1.3.3
17 changes: 14 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,20 @@
'PyYAML',
'tenacity',
'python-libmaas',

# https://github.com/go-macaroon-bakery/py-macaroon-bakery/issues/94
'macaroonbakery != 1.3.3',
# protobuf dropped support for python-3.6 in v3.20.0[0], although it wasn't
# until 4.21.0 that it became truly incompatible. The pinning used is
# `<4.21.0`
#
# [0] https://github.com/protocolbuffers/protobuf/commit/301d315dc4674d1bc799446644e88eff0af1ac86 # noqa
# [1] https://github.com/protocolbuffers/protobuf/issues/10076
'protobuf < 4.21.0',
# macaroonbakery in v1.3.4 added a constraint of protobuf>=3.20.0[0] which
# makes it incompatible with python 3.6 while v1.3.3 was released in a
# broken state[1]
#
# [0] https://github.com/go-macaroon-bakery/py-macaroon-bakery/commit/7f1fe6a2adb2f80db12bccfb81f629d66d106e03 # noqa
# [1] https://github.com/go-macaroon-bakery/py-macaroon-bakery/pull/92
'macaroonbakery < 1.3.3',
]

tests_require = [
Expand Down
Loading