Fix Code becoming integer. #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Value of the Code key in the returned Dict is str in master branch. However while trying to get compatible with juju 3.x series it became int. Now it is not conforming to the function signature. Also there are usages in some tests so it reverted back to str.
Merged
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
|
The failure is not related to the change, and this will be a short lived branch. Merging on that basis. |
ajkavanagh
merged commit 6e3b91b
into
openstack-charmers:libjuju-3.1
5 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value of the Code key in the returned Dict is str in master branch. However while trying to get compatible with juju 3.x series it became int. Now it is not conforming to the function signature. Also there are usages in some tests so it reverted back to str.