Handle instances without attached ports. #772
Draft
+62
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://review.opendev.org/c/openstack/charm-manila/+/843217 - ci job exercising the change. |
This change covers the case where an instance has no ports (addresses)
attached making the function network_name_from_instance() raise a
StopIteration since the "addresses" dict is empty.
Traceback (most recent call last):
File "[...]/zaza/openstack/charm_tests/manila/tests.py", line 142, in tearDownClass
fips_reservations += neutron_tests.floating_ips_from_instance(vm)
File "[...[/zaza/openstack/charm_tests/neutron/tests.py", line 1028, in floating_ips_from_instance
return ips_from_instance(instance, 'floating')
File "[...]/zaza/openstack/charm_tests/neutron/tests.py", line 1073, in ips_from_instance
network_name_from_instance(instance)]
File "[...]/zaza/openstack/charm_tests/neutron/tests.py", line 1052, in network_name_from_instance
return next(iter(instance.addresses))
StopIteration
Fixes openstack-charmers#771
freyes
force-pushed
the
fix-stop-iteration
branch
from
00ed6d3 to
ac77f24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change covers the case where an instance has no ports (addresses)
attached making the function network_name_from_instance() raise a
StopIteration since the "addresses" dict is empty.
Traceback (most recent call last):
File "[...]/zaza/openstack/charm_tests/manila/tests.py", line 142, in tearDownClass
fips_reservations += neutron_tests.floating_ips_from_instance(vm)
File "[...[/zaza/openstack/charm_tests/neutron/tests.py", line 1028, in floating_ips_from_instance
return ips_from_instance(instance, 'floating')
File "[...]/zaza/openstack/charm_tests/neutron/tests.py", line 1073, in ips_from_instance
network_name_from_instance(instance)]
File "[...]/zaza/openstack/charm_tests/neutron/tests.py", line 1052, in network_name_from_instance
return next(iter(instance.addresses))
StopIteration
Fixes #771