-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switched printDescription
and printDescriptionImpl
log_cout
s to log_info
s
#3888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 27 of 27 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AllisonJohn)
CHANGELOG.md
line 19 at r1 (raw file):
occurring in the output. (#3867) - Added `Output`s to `ExpressionBasedCoordinateForce`, `ExpressionBasedPointToPointForce`, and `ExpressionBasedBushingForce` for accessing force values. (#3872) - Changed all `printDescription()` and `printDescriptionImpl()` methods to log at level info instead of cout. (#3888)
I think we should update the Moco changelog instead, since this change only affects MocoProblem print statements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nickbianco)
CHANGELOG.md
line 19 at r1 (raw file):
Previously, nickbianco (Nick Bianco) wrote…
I think we should update the Moco changelog instead, since this change only affects MocoProblem print statements.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AllisonJohn)
Fixes issue #3861
Brief summary of changes
Changed any print methods called by MocoProblemRep::printDescription()
Testing I've completed
Tested for one example problem with two types of goals, did not test every single printDescriptionImpl
Looking for feedback on...
CHANGELOG.md (choose one)
updated
This change is