Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched printDescription and printDescriptionImpl log_couts to log_infos #3888

Merged
merged 6 commits into from
Aug 27, 2024

Conversation

AllisonJohn
Copy link
Member

@AllisonJohn AllisonJohn commented Aug 23, 2024

Fixes issue #3861

Brief summary of changes

Changed any print methods called by MocoProblemRep::printDescription()

Testing I've completed

Tested for one example problem with two types of goals, did not test every single printDescriptionImpl

Looking for feedback on...

CHANGELOG.md (choose one)

updated


This change is Reviewable

@AllisonJohn AllisonJohn marked this pull request as draft August 23, 2024 23:09
@AllisonJohn AllisonJohn marked this pull request as ready for review August 26, 2024 17:35
Copy link
Member

@nickbianco nickbianco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 27 of 27 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AllisonJohn)


CHANGELOG.md line 19 at r1 (raw file):

  occurring in the output. (#3867)
- Added `Output`s to `ExpressionBasedCoordinateForce`, `ExpressionBasedPointToPointForce`, and `ExpressionBasedBushingForce` for accessing force values. (#3872)
- Changed all `printDescription()` and `printDescriptionImpl()` methods to log at level info instead of cout. (#3888)

I think we should update the Moco changelog instead, since this change only affects MocoProblem print statements.

Copy link
Member Author

@AllisonJohn AllisonJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nickbianco)


CHANGELOG.md line 19 at r1 (raw file):

Previously, nickbianco (Nick Bianco) wrote…

I think we should update the Moco changelog instead, since this change only affects MocoProblem print statements.

Done.

Copy link
Member

@nickbianco nickbianco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AllisonJohn)

@nickbianco nickbianco merged commit a18df1c into opensim-org:main Aug 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants