Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix matlab tests #3886

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Fix matlab tests #3886

merged 3 commits into from
Sep 27, 2024

Conversation

aymanhab
Copy link
Member

@aymanhab aymanhab commented Aug 21, 2024

Fixes issue #0

Brief summary of changes

fix 2 matlab test cases ta\hat fail locally

Testing I've completed

ran tests locally and they pass, one failure left Matlab_MocoWorkflow_Release though the problem solves, may need a look by @nickbianco to understand the issue

Looking for feedback on...

CHANGELOG.md (choose one)

  • no need to update because Matlab tests are not exposed to users

This change is Reviewable

@aymanhab
Copy link
Member Author

@nickbianco This should fix the lingering matlab test failures for developers who happen to have matlab locally installed. Also to make our published codebase/tests consistent with our own API. Not urgent since broken for years..

Copy link
Member

@nickbianco nickbianco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just had one quick comment, but it's not blocking.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aymanhab)


Bindings/Java/Matlab/tests/testOsimC3D.m line 111 at r1 (raw file):

            assert(abs(d.get(0)-d_m.get(0))<.001,'Force Data has been incorrectly altered');
            assert(abs(d.get(1)-d_m.get(1))<.001,'Force Data has been incorrectly altered');
            assert(abs(d.get(2)-d_m.get(2))<.001,'Force Data has been incorrectly altered');

I assume these tests were failing to some relatively high precision?

@aymanhab
Copy link
Member Author

Thanks @nickbianco The old test was using plain equality of doubles after performing transformation/matrixt multiplication!

@aymanhab
Copy link
Member Author

Thanks @nickbianco 👍

@aymanhab aymanhab merged commit cbf9c74 into main Sep 27, 2024
11 of 12 checks passed
@aymanhab aymanhab deleted the fix_matlab_tests branch September 27, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants