Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.13] Prevent some submodule auto-updates #2559

Open
wants to merge 1 commit into
base: release-4.13
Choose a base branch
from
Open

[release-4.13] Prevent some submodule auto-updates #2559

wants to merge 1 commit into from
+272 −0

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2546

/assign sebsoto

@sebsoto
Prevent some submodule auto-updates
fd9ece6 
Adds a renovate.json from
https://github.com/konflux-ci/mintmaker/blob/main/config/renovate/renovate.json

This is the default config that konflux uses. I added an ignoreDeps
field to prevent the kubelet, kube-proxy, and containerd submodules from
being updated automatically. This is because they need to be updated
using hack/update-submodules.sh, in order to present the correct
versioning.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 25, 2024
Merged
@jrvaldes
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2024
@sebsoto
Copy link
Contributor

sebsoto commented Nov 25, 2024

/approve

@sebsoto
Copy link
Contributor

sebsoto commented Nov 25, 2024

/override ci/prow/aws-e2e-operator ci/prow/azure-e2e-operator ci/prow/azure-e2e-upgrade ci/prow/gcp-e2e-operator ci/prow/nutanix-e2e-operator ci/prow/platform-none-vsphere-e2e-operator ci/prow/vsphere-proxy-e2e-operator ci/prow/vsphere-e2e-operator ci/prow/wicd-unit-vsphere

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

@sebsoto: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ci/prow/nutanix-e2e-operator
  • ci/prow/vsphere-proxy-e2e-operator

Only the following failed contexts/checkruns were expected:

  • ci/prow/aws-e2e-operator
  • ci/prow/azure-e2e-operator
  • ci/prow/azure-e2e-upgrade
  • ci/prow/build
  • ci/prow/ci-bundle-wmco-bundle
  • ci/prow/gcp-e2e-operator
  • ci/prow/images
  • ci/prow/lint
  • ci/prow/platform-none-vsphere-e2e-operator
  • ci/prow/security
  • ci/prow/unit
  • ci/prow/vsphere-e2e-operator
  • ci/prow/wicd-unit-vsphere
  • pull-ci-openshift-windows-machine-config-operator-master-aws-e2e-operator
  • pull-ci-openshift-windows-machine-config-operator-master-azure-e2e-operator
  • pull-ci-openshift-windows-machine-config-operator-master-azure-e2e-upgrade
  • pull-ci-openshift-windows-machine-config-operator-master-build
  • pull-ci-openshift-windows-machine-config-operator-master-ci-bundle-wmco-bundle
  • pull-ci-openshift-windows-machine-config-operator-master-gcp-e2e-operator
  • pull-ci-openshift-windows-machine-config-operator-master-images
  • pull-ci-openshift-windows-machine-config-operator-master-lint
  • pull-ci-openshift-windows-machine-config-operator-master-platform-none-vsphere-e2e-operator
  • pull-ci-openshift-windows-machine-config-operator-master-security
  • pull-ci-openshift-windows-machine-config-operator-master-unit
  • pull-ci-openshift-windows-machine-config-operator-master-vsphere-e2e-operator
  • pull-ci-openshift-windows-machine-config-operator-master-wicd-unit-vsphere
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ci/prow/aws-e2e-operator ci/prow/azure-e2e-operator ci/prow/azure-e2e-upgrade ci/prow/gcp-e2e-operator ci/prow/nutanix-e2e-operator ci/prow/platform-none-vsphere-e2e-operator ci/prow/vsphere-proxy-e2e-operator ci/prow/vsphere-e2e-operator ci/prow/wicd-unit-vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1e8da79 and 2 for PR HEAD fd9ece6 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1e8da79 and 2 for PR HEAD fd9ece6 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/azure-e2e-operator fd9ece6 link true /test azure-e2e-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansikulkarni96 mansikulkarni96 Awaiting requested review from mansikulkarni96

@sebsoto sebsoto Awaiting requested review from sebsoto

Assignees

@sebsoto sebsoto

@jrvaldes jrvaldes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-cherrypick-robot @jrvaldes @sebsoto @openshift-ci-robot