OCPBUGS-43745: Add support for IdleCloseTerminationPolicy

[frobware]

Replace the hard-coded idle-close-on-response setting with a conditional based on the IngressController's spec.idleConnectionTerminationPolicy field, which controls whether HAProxy maintains idle frontend connections during reloads or closes them immediately.

The default behaviour for OCP 4.19 returns to closing idle connections immediately, reversing https://issues.redhat.com/browse/OCPBUGS-32044 which had made 'option idle-close-on-response' always present in the HAProxy configuration.

References:

• The field idleConnectionTerminationPolicy was added in OCPBUGS-43745: Add IdleCloseOnResponse field to IngressControllerSpec api#2102
• cluster-ingress-operator e2e test in OCPBUGS-43745: Add support for IdleCloseTerminationPolicy cluster-ingress-operator#1166

[openshift-ci-robot]

@frobware: This pull request references Jira Issue OCPBUGS-43745, which is invalid:

• expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Replace the hard-coded idle-close-on-response setting with a conditional
based on the IngressController's spec.idleConnectionTerminationPolicy
field, which controls whether HAProxy maintains idle frontend
connections during reloads or closes them immediately.

The default behaviour returns to closing idle connections immediately,
reversing https://issues.redhat.com/browse/OCPBUGS-32044 which had made
'option idle-close-on-response' always present in the configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@frobware: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	66f932a	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[alebedev87]

/assign

[candita]

/assign @grzpiotrowski

[frobware]

/jira refresh

[openshift-ci-robot]

@frobware: This pull request references Jira Issue OCPBUGS-43745, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[grzpiotrowski]

/lgtm

Leaving the final approve to @alebedev87

[alebedev87]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alebedev87]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[grzpiotrowski]

Looks like we need the acknowledge-critical-fixes-only label for it to move