Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-42045: Add IBM Public Cloud PreSubmit E2E for Ingress Operator #56785

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

gcs278
Copy link
Contributor

@gcs278 gcs278 commented Sep 16, 2024

The Ingress Operator was lacking a presubmit E2E job for IBM Public Cloud. This change adds a IBM Public Cloud presubmit job as optional and always_run=false so that we can identify issues in CI.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 16, 2024
@openshift-ci-robot
Copy link
Contributor

@gcs278: This pull request references Jira Issue OCPBUGS-42045, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The Ingress Operator was lacking a presubmit E2E job for IBM Public Cloud. As a result, a bug was exposed that otherwise would have been caught by our E2E tests. This change adds a IBM Public Cloud presubmit job so that we can identify issues in CI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from knobunc and rfredette September 16, 2024 19:48
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@gcs278
Copy link
Contributor Author

gcs278 commented Sep 16, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 16, 2024
@openshift-ci-robot
Copy link
Contributor

@gcs278: This pull request references Jira Issue OCPBUGS-42045, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from lihongan September 16, 2024 19:49
@gcs278
Copy link
Contributor Author

gcs278 commented Sep 16, 2024

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@gcs278: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@gcs278
Copy link
Contributor Author

gcs278 commented Sep 16, 2024

/pj-rehearse pull-ci-openshift-cluster-ingress-operator-master-e2e-ibmcloud-operator

@openshift-ci-robot
Copy link
Contributor

@gcs278: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@gcs278: This pull request references Jira Issue OCPBUGS-42045, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

The Ingress Operator was lacking a presubmit E2E job for IBM Public Cloud. This change adds a IBM Public Cloud presubmit job so that we can identify issues in CI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gcs278 gcs278 force-pushed the add-ibm-cloud-e2e branch 2 times, most recently from bf97d35 to 2781cac Compare September 16, 2024 22:01
@gcs278
Copy link
Contributor Author

gcs278 commented Sep 16, 2024

Not that bad first run, looks like the issue is Load Balancer HostName resolution. It's taking over 5 minutes for IBM Public Cloud. I think it's related to https://issues.redhat.com/browse/OCPBUGS-14966

@gcs278
Copy link
Contributor Author

gcs278 commented Sep 16, 2024

/pj-rehearse pull-ci-openshift-cluster-ingress-operator-master-e2e-ibmcloud-operator

@openshift-ci-robot
Copy link
Contributor

@gcs278: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@gcs278
Copy link
Contributor Author

gcs278 commented Sep 16, 2024

CI infra issue:

/pj-rehearse pull-ci-openshift-cluster-ingress-operator-master-e2e-ibmcloud-operator

@openshift-ci-robot
Copy link
Contributor

@gcs278: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@@ -1107,6 +1107,85 @@ presubmits:
secret:
secretName: result-aggregator
trigger: (?m)^/test( | .* )e2e-hypershift,?($|\s.*)
- agent: kubernetes
always_run: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be always_run: false, at least initially?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good idea to get started. We can always come back and update it. Done.

@Miciah
Copy link
Contributor

Miciah commented Sep 18, 2024

/assign

@openshift-ci-robot
Copy link
Contributor

@gcs278: This pull request references Jira Issue OCPBUGS-42045, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

The Ingress Operator was lacking a presubmit E2E job for IBM Public Cloud. This change adds a IBM Public Cloud presubmit job as optional and always_run=false so that we can identify issues in CI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e471542 and 1 for PR HEAD 0e2bb9b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 467f9b1 and 0 for PR HEAD 0e2bb9b in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 0e2bb9b was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2024
@gcs278 gcs278 force-pushed the add-ibm-cloud-e2e branch from 0e2bb9b to 3151642 Compare October 10, 2024 13:18
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
@gcs278
Copy link
Contributor Author

gcs278 commented Oct 10, 2024

@Miciah I think a recent update caused ci/prow/ordered-prow-config to fail and required me to run make jobs again. I also rebased to be safe.

Could I get another LGTM please?

@gcs278 gcs278 force-pushed the add-ibm-cloud-e2e branch from 3151642 to d02c803 Compare October 10, 2024 13:32
@gcs278
Copy link
Contributor Author

gcs278 commented Oct 10, 2024

Whoops, did make jobs, then rebase, and needed to do another make jobs. Should be good now.

Copy link
Contributor

openshift-ci bot commented Oct 10, 2024

@gcs278: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-ingress-operator/master/e2e-ibmcloud-operator 0e2bb9b link unknown /pj-rehearse pull-ci-openshift-cluster-ingress-operator-master-e2e-ibmcloud-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 10, 2024
@Miciah
Copy link
Contributor

Miciah commented Oct 10, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
The Ingress Operator was lacking a presubmit E2E job for IBM Public
Cloud. This change adds a IBM Public Cloud presubmit job as optional
and always_run=false so that we can identify issues in CI.
@gcs278 gcs278 force-pushed the add-ibm-cloud-e2e branch from d02c803 to e8702da Compare October 10, 2024 21:39
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@gcs278: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-ingress-operator-master-e2e-ibmcloud-operator openshift/cluster-ingress-operator presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@gcs278
Copy link
Contributor Author

gcs278 commented Oct 10, 2024

@Miciah sorry, #57477 caused a merge conflict, and had to rebase again.

Could I get another LGTM please?

@gcs278
Copy link
Contributor Author

gcs278 commented Oct 11, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2024
@gcs278
Copy link
Contributor Author

gcs278 commented Oct 11, 2024

Nothing changed since the last ack, and the CI job is expected to fail anyways.
/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@gcs278: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 11, 2024
@Miciah
Copy link
Contributor

Miciah commented Oct 11, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2024
Copy link
Contributor

openshift-ci bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gcs278, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 281d05d into openshift:master Oct 11, 2024
15 checks passed
@openshift-ci-robot
Copy link
Contributor

@gcs278: Jira Issue OCPBUGS-42045: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42045 has been moved to the MODIFIED state.

In response to this:

The Ingress Operator was lacking a presubmit E2E job for IBM Public Cloud. This change adds a IBM Public Cloud presubmit job as optional and always_run=false so that we can identify issues in CI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

josecastillolema pushed a commit to josecastillolema/release that referenced this pull request Oct 15, 2024
openshift#56785)

The Ingress Operator was lacking a presubmit E2E job for IBM Public
Cloud. This change adds a IBM Public Cloud presubmit job as optional
and always_run=false so that we can identify issues in CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants