Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the logging view plugin CI config match its Dockerfile.ci #46011

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Make the logging view plugin CI config match its Dockerfile.ci #46011

merged 1 commit into from
Nov 28, 2023

Conversation

syedriko
Copy link
Contributor

@syedriko syedriko commented Nov 24, 2023 •
edited
Loading

Make the logging view plugin CI config match its Dockerfile.ci

This is to unblock ViaQ/vector#169, where quay.io/openshift-logging/logging-view-plugin:5.6 base image is RHEL8 but the build image is RHEL9:

$ podman run -it --rm quay.io/openshift-logging/logging-view-plugin:5.6
./plugin-backend: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by ./plugin-backend)
./plugin-backend: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by ./plugin-backend)
$

@openshift-ci openshift-ci bot requested review from kyoto and zhuje November 24, 2023 02:06
@syedriko syedriko force-pushed the syedriko-logging-view-plugin-ci-config branch from 4fbb5e4 to e551d2a Compare November 24, 2023 02:19
@syedriko
Copy link
Contributor Author

/pj-rehearse

@syedriko syedriko force-pushed the syedriko-logging-view-plugin-ci-config branch from e551d2a to 2017a0e Compare November 24, 2023 03:03
@syedriko
Copy link
Contributor Author

/retest

@syedriko
Copy link
Contributor Author

/pj-rehearse

@syedriko syedriko force-pushed the syedriko-logging-view-plugin-ci-config branch from 2017a0e to 5dd920a Compare November 24, 2023 04:59
@syedriko
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-logging-view-plugin-release-5.6-images

@syedriko
Copy link
Contributor Author

/pj-rehearse

@syedriko syedriko force-pushed the syedriko-logging-view-plugin-ci-config branch from 5dd920a to 4704dea Compare November 24, 2023 06:45
@syedriko syedriko changed the title Correct logging view plugin CI config Make the logging view plugin CI config match its Dockerfile.ci Nov 24, 2023
@syedriko
Copy link
Contributor Author

/pj-rehearse

1 similar comment
@syedriko
Copy link
Contributor Author

/pj-rehearse

@syedriko
Copy link
Contributor Author

/retest

@syedriko
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-logging-view-plugin-release-5.6-images
/pj-rehearse pull-ci-openshift-logging-view-plugin-release-5.6-test-unit
/pj-rehearse pull-ci-openshift-logging-view-plugin-release-5.6-test-e2e

@syedriko
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-logging-view-plugin-release-5.6-test-unit

@syedriko
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-logging-view-plugin-release-5.6-test-e2e

@syedriko
Copy link
Contributor Author

/cc @jcantrill
/assign @jcantrill

@syedriko
Copy link
Contributor Author

@jcantrill The 'as' clauses are good as they are because of https://steps.ci.openshift.org/ci-operator-reference#line70. The image nicknames are coming from different namespaces:

inputs:
  go-builder: // refers to a base image
    as:
    - go-builer // refers to the nickname of 'FROM registry.redhat.io/ubi9/go-toolset:1.19 as go-builder'

I'd prefer to keep it this way because the nicknames are more stable than full image paths and don't change with UBI or Go versions.

@syedriko syedriko force-pushed the syedriko-logging-view-plugin-ci-config branch from 4704dea to cef6774 Compare November 27, 2023 16:27
@syedriko
Copy link
Contributor Author

/pj-rehearse

@syedriko syedriko force-pushed the syedriko-logging-view-plugin-ci-config branch from cef6774 to fd5d3ce Compare November 27, 2023 17:24
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@syedriko: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-logging-view-plugin-release-5.8-images openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-release-5.8-lint openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-release-5.8-test-e2e openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-release-5.8-test-unit openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-main-images openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-main-lint openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-main-test-e2e openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-main-test-unit openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-release-5.7-images openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-release-5.7-lint openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-release-5.7-test-e2e openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-release-5.7-test-unit openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-release-5.6-images openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-release-5.6-lint openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-release-5.6-test-e2e openshift/logging-view-plugin presubmit Ci-operator config changed
pull-ci-openshift-logging-view-plugin-release-5.6-test-unit openshift/logging-view-plugin presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@syedriko
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-logging-view-plugin-release-5.6-images

@syedriko
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-logging-view-plugin-release-main-images

@openshift-ci-robot
Copy link
Contributor

@syedriko: job(s): pull-ci-openshift-logging-view-plugin-release-main-images either don't exist or were not found to be affected, and cannot be rehearsed

@syedriko
Copy link
Contributor Author

/pj-rehearse

1 similar comment
@syedriko
Copy link
Contributor Author

/pj-rehearse

@syedriko
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-logging-view-plugin-main-test-unit
/pj-rehearse pull-ci-openshift-logging-view-plugin-main-test-e2e

@syedriko
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-logging-view-plugin-release-5.8-images
/pj-rehearse pull-ci-openshift-logging-view-plugin-release-5.8-lint
/pj-rehearse pull-ci-openshift-logging-view-plugin-release-5.8-test-unit
/pj-rehearse pull-ci-openshift-logging-view-plugin-release-5.8-test-e2e

@syedriko
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-logging-view-plugin-main-test-e2e

@syedriko
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-logging-view-plugin-release-5.8-lint pull-ci-openshift-logging-view-plugin-release-5.8-test-unit pull-ci-openshift-logging-view-plugin-release-5.8-test-e2e

@jcantrill
Copy link
Contributor

/approve
/lgtm

@jcantrill
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 28, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
@jcantrill
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, syedriko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

@syedriko: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 44eea7f into openshift:master Nov 28, 2023
32 checks passed
Neha-dot-Yadav pushed a commit to Neha-dot-Yadav/release that referenced this pull request Nov 30, 2023
@syedriko @Neha-dot-Yadav
Make the logging view plugin CI config match its Dockerfile.ci (opens…
319a4a1 
…hift#46011)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyoto kyoto Awaiting requested review from kyoto

@zhuje zhuje Awaiting requested review from zhuje

@jcantrill jcantrill Awaiting requested review from jcantrill

Assignees

@jcantrill jcantrill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syedriko @openshift-ci-robot @jcantrill