Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-43478: generalize the RHEL8 and RHEL9 subscription_content.go test #29315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chandra0007
Copy link

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 21, 2024
@openshift-ci-robot
Copy link

@chandra0007: This pull request references Jira Issue OCPBUGS-43478, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 21, 2024
Copy link
Contributor

@prb112 prb112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits...
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@prb112
Copy link
Contributor

prb112 commented Nov 21, 2024

/retest-required

Copy link

openshift-trt bot commented Nov 21, 2024

Job Failure Risk Analysis for sha: 3ba811b

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6 Medium
[sig-arch][Late] operators should not create watch channels very often [apigroup:apiserver.openshift.io] [Suite:openshift/conformance/parallel]
This test has passed 87.04% of 54 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6' 'periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6'] in the last 14 days.

Open Bugs
Component Readiness: [Unknown] [Other] test regressed

Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2024
@chandra0007
Copy link
Author

/retest-required

@prb112
Copy link
Contributor

prb112 commented Nov 25, 2024

e2e-gcp-ovn-builds is blocked by https://issues.redhat.com/browse/OCPBUGS-44257

Copy link
Contributor

@prb112 prb112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on a review, these changes make sense. I'll watch the verify job.

Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chandra0007, prb112
Once this PR has been reviewed and has the lgtm label, please assign sayan-biswas for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@prb112
Copy link
Contributor

prb112 commented Nov 26, 2024

Hey @adambkaplan I hope you are well. We are updating the subscription_content.go tests to be multiarch. Could you review / approve or assign? Thanks, Paul

@prb112
Copy link
Contributor

prb112 commented Nov 26, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

@chandra0007: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 2149030 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-metal-ipi-ovn 2149030 link false /test e2e-metal-ipi-ovn
ci/prow/e2e-aws-ovn-single-node-upgrade 2149030 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-openstack-ovn 2149030 link false /test e2e-openstack-ovn
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout 2149030 link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-agnostic-ovn-cmd 2149030 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-gcp-ovn-builds 2149030 link true /test e2e-gcp-ovn-builds

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-trt bot commented Nov 26, 2024

Job Failure Risk Analysis for sha: 2149030

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade High
[sig-network] pods should successfully create sandboxes by pinging container registry
This test has passed 100.00% of 154 runs on release 4.19 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week.
---
[sig-cluster-lifecycle] pathological event should not see excessive Back-off restarting failed containers for ns/openshift-kube-controller-manager
This test has passed 100.00% of 154 runs on release 4.19 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:single Upgrade:micro] in the last week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants