-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-43478: generalize the RHEL8 and RHEL9 subscription_content.go test #29315
base: master
Are you sure you want to change the base?
Conversation
@chandra0007: This pull request references Jira Issue OCPBUGS-43478, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nits...
/lgtm
/retest-required |
Job Failure Risk Analysis for sha: 3ba811b
|
New changes are detected. LGTM label has been removed. |
/retest-required |
e2e-gcp-ovn-builds is blocked by https://issues.redhat.com/browse/OCPBUGS-44257 |
… test Signed-off-by: Chandrasekhar B <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on a review, these changes make sense. I'll watch the verify job.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chandra0007, prb112 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hey @adambkaplan I hope you are well. We are updating the subscription_content.go tests to be multiarch. Could you review / approve or assign? Thanks, Paul |
/retest |
@chandra0007: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Job Failure Risk Analysis for sha: 2149030
|
No description provided.