OCPBUGS-45663: dynamically setting the amount of fault domains #124
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
sunzhaohua2
force-pushed
the
45663
branch
2 times, most recently
from
ba3944b to
ce4728d
Compare
sunzhaohua2
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-ci-robot
added
jira/severity-moderate
|
@sunzhaohua2: This pull request references Jira Issue OCPBUGS-45663, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| skuI, err := skuService.Get(ctx, skuSpec) | ||
| if err != nil { | ||
| if errors.Is(err, resourceskus.ErrResourceNotFound) { | ||
| return machinecontroller.InvalidMachineConfiguration("failed to obtain availability set information for Aligned '%s' from Azure: %s", skuSpec.Name, err) |
There was a problem hiding this comment.
what does "Aligned" mean here?
There was a problem hiding this comment.
@elmiko Thank you for helping review, I updated, "Aligned" mean Aligned SKU type.
|
|
||
| sku := skuI.(resourceskus.SKU) | ||
|
|
||
| fmt.Printf("Capabilities: %+v\n", sku.Capabilities) |
There was a problem hiding this comment.
this should be a log call, perhaps klog.Infof("Capabilities: %+v\n", sku.Capabilities)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@sunzhaohua2: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I tried to dynamically set the amount of fault domains, install cluster with this pr on region "northcentralus", after installation scale up machineset, I can see the amount of fault domains is 3 instead of 2. https://drive.google.com/file/d/1Rc1zCKts0gywhF_HyaoKm-xPfN_Snr-n/view?usp=sharing