Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE-6763: pkg/infrastructure/azure: support nvme #9232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

patrickdillon
Copy link
Contributor

Updates the installer-generated image definition to indicate support for NVME (and SCSI) disk controllers. Without this feature on the image definition, certain VM families will fail to provision with a message such as:

The VM size 'Standard_D8ds_v6' cannot boot with OS image or disk. Please check that disk controller types supported by the OS image or disk is one of the supported disk controller types for the VM size 'Standard_D8ds_v6'.

With the change in this commit, the VM will successfully provision.

Updates the installer-generated image definition to indicate support
for NVME (and SCSI) disk controllers. Without this feature on the
image definition, certain VM families will fail to provision with
a message such as:

The VM size 'Standard_D8ds_v6' cannot boot with OS image or disk.
Please check that disk controller types supported by the OS image or
disk is one of the supported disk controller types for the VM size
'Standard_D8ds_v6'.

With the change in this commit, the VM will successfully provision.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 22, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 22, 2024

@patrickdillon: This pull request references RFE-6763 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target the "4.18.0" version, but no target version was set.

In response to this:

Updates the installer-generated image definition to indicate support for NVME (and SCSI) disk controllers. Without this feature on the image definition, certain VM families will fail to provision with a message such as:

The VM size 'Standard_D8ds_v6' cannot boot with OS image or disk. Please check that disk controller types supported by the OS image or disk is one of the supported disk controller types for the VM size 'Standard_D8ds_v6'.

With the change in this commit, the VM will successfully provision.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from patrickdillon. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Nov 23, 2024

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 6d7d4af link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azurestack 6d7d4af link false /test e2e-azurestack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants