DNM/SPLAT-1860: aws - track CAPA 4917 #9131
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/test ? |
|
@mtulio: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test altinfra-e2e-aws-ovn-shared-vpc |
|
cc @r4f4 to track OCP impact by kubernetes-sigs/cluster-api-provider-aws#5175 on managed/unmapaned VPC scenarios. |
mtulio
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@mtulio: This pull request references SPLAT-1860 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
go.mod was crashing due new CAPI dependencies. Creating this hotfix to quickly check e2e // mtulio fix-capa-4917 giantswarm:fix-tag-subnets replace sigs.k8s.io/cluster-api-provider-aws/v2 => github.com/giantswarm/cluster-api-provider-aws/v2 v2.6.1-0.20241023072232-c8eb4797b15e
|
/test altinfra-e2e-aws-ovn-shared-vpc |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
IIUC not at all jobs are exercising tags, specially for BYO VPC to test CAPA#5171. Testing the basic changes; /test e2e-aws-ovn |
|
@mtulio it seems to be fine? It kept existing tags, including the "k8s: shared" installer-added one. - id: subnet-022372a8a97126bd4
resourceid: subnet-022372a8a97126bd4
cidrblock: 10.0.48.0/20
ipv6cidrblock: ""
availabilityzone: us-east-1a
ispublic: false
isipv6: false
routetableid: rtb-0c2f14d8ac0816126
natgatewayid: null
tags:
aws:cloudformation:logical-id: PrivateSubnet
aws:cloudformation:stack-id: arn:aws:cloudformation:us-east-1:460538899914:stack/ci-op-nybl0rdv-85edf-shared-vpc/c0c489a0-917d-11ef-8df4-0affc13b32f3
aws:cloudformation:stack-name: ci-op-nybl0rdv-85edf-shared-vpc
ci-build-info: 1849178330570428416_pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn-shared-vpc
expirationDate: 2024-10-24T00:31+00:00
kubernetes.io/cluster/ci-op-nybl0rdv-85edf-clz9j: shared
zonetype: availability-zone
parentzonename: nullwhich is very similar to the output from another job without the CAPA changes: - id: subnet-03227b5289b4a64f4
resourceid: subnet-03227b5289b4a64f4
cidrblock: 10.0.48.0/20
ipv6cidrblock: ""
availabilityzone: us-west-2a
ispublic: false
isipv6: false
routetableid: rtb-08fbaea9464237fec
natgatewayid: null
tags:
aws:cloudformation:logical-id: PrivateSubnet
aws:cloudformation:stack-id: arn:aws:cloudformation:us-west-2:460538899914:stack/ci-op-1m6j03lr-ff55c-shared-vpc/3694ef90-9092-11ef-8c85-06fb3556500d
aws:cloudformation:stack-name: ci-op-1m6j03lr-ff55c-shared-vpc
ci-build-info: 1848743677787115520_pull-ci-openshift-installer-master-e2e-aws-ovn-shared-vpc-custom-security-groups
expirationDate: 2024-10-22T20:25+00:00
kubernetes.io/cluster/ci-op-1m6j03lr-ff55c-7p4zm: shared
zonetype: availability-zone
parentzonename: null |
|
In the job 1849178330570428416 (BYO VPC deployment), I can see the custom tags on install-config: And the subnet on CAPA cluster object has only original tags from subnet: I can confirm that the object hasn't the expected tag: $ aws ec2 describe-subnets --subnet-ids subnet-022372a8a97126bd4 --region us-east-1 | jq -rc '.Subnets[].Tags[]'
{"Key":"aws:cloudformation:stack-id","Value":"arn:aws:cloudformation:us-east-1:[...]:stack/ci-op-nybl0rdv-85edf-shared-vpc/c0c489a0-917d-11ef-8df4-0affc13b32f3"}
{"Key":"aws:cloudformation:logical-id","Value":"PrivateSubnet"}
{"Key":"openshift_creationDate","Value":"2024-10-23T21:05:42.610615+00:00"}
{"Key":"ci-build-info","Value":"1849178330570428416_pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn-shared-vpc"}
{"Key":"kubernetes.io/cluster/ci-op-nybl0rdv-85edf-clz9j","Value":"shared"}
{"Key":"aws:cloudformation:stack-name","Value":"ci-op-nybl0rdv-85edf-shared-vpc"}
{"Key":"expirationDate","Value":"2024-10-24T00:31+00:00"}
Need to check:
|
For BYO subnets, we don't want them to be applied. Customers can tag their own BYO resources. The |
|
@mtulio: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Yes: And looks like CAPA follow the same meaning: https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/5175/files#r1814372499 Although, CAPA#5175 intents to address that scenario (tag BYO subnet), I just checked we are not setting tags to subnets: https://github.com/openshift/installer/blob/master/pkg/asset/manifests/aws/zones.go Probably we'll not affected by that change/fix. |
@mtulio thanks for checking and for keeping an eye on possibly impactful changes in upstream CAPA! |
No description provided.