Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNM: devel tests for CAPI/CAPA w/ upstream #8109

Closed
wants to merge 15 commits into from
Closed

DNM: devel tests for CAPI/CAPA w/ upstream #8109

wants to merge 15 commits into from

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Mar 6, 2024 •
edited
Loading

Pr used to provision AWS clusters with CAPA in the development phase (CORS-2890).

This PR was built upon #8074

This PR picks the following upstream changes:

Marked as done when merged and rebased

@patrickdillon
cluster-api/providers/aws: vendor dual LB
f9f8328
@patrickdillon
cluster-api/providers/aws: vendor
9cb2dd3 
go mod tidy && go mod vendor
@patrickdillon
cluster-api: update aws-infrastructure-components
10fa7c2 
update aws-infrastructure-components for newly vendored aws capi
provider controller.
@patrickdillon
vendor: cluster-api-provider-aws/v2
5aaba36 
require aws capi provider to include dual load balancer support
@patrickdillon
WIP remove v1alpha3 capi package
69d0a47 
for some reason vendoring newer capa causes go mod tidy to fail that
this can't be found. seems unused
@patrickdillon
vendor capa dual lb
554602f
@patrickdillon
wip add secondary lb
24b412b
@patrickdillon
WIP create IAM and DNS
bbed16c
@patrickdillon
DNM fix upstream CAPA bug
a8fa806
@patrickdillon
WIP: figuring out ingress rules
31a0e7d
@patrickdillon
WIP switch public api sg to internal lb. bug?
2b2de8e
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mtulio mtulio changed the title DON'T MERGE/TMP | devel installer CAPI/CAPA TMP/don't merge | devel installer CAPI/CAPA Mar 6, 2024
@mtulio
devel: capa provisioning including unmerged upstream
9305e54 
Changes:

- downstream fixes: s3 loc and lb subnet
- elbv2 must check the correct scheme
- API health check must have the correct health check when using HTTP or
  HTTPS
- Control plane load balancers must allow customization for health
  check, considering additional listeners
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign annazivkovic for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtulio mtulio force-pushed the capa-devel-mrbraga branch from 112d778 to 9305e54 Compare March 6, 2024 16:31
@mtulio mtulio changed the title TMP/don't merge | devel installer CAPI/CAPA DNM: devel tests for CAPI/CAPA w/ upstream Mar 14, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

@mtulio: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/altinfra-openstack-capi-manifests 5ad76f8 link true /test altinfra-openstack-capi-manifests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mtulio
Copy link
Contributor Author

mtulio commented Apr 12, 2024

Closing as all changes/features have been addressed to dedicated PRs for installer and CAPA.

@mtulio mtulio closed this Apr 12, 2024
@mtulio mtulio deleted the capa-devel-mrbraga branch April 12, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtulio @openshift-merge-robot @patrickdillon