Bump bootstrap in place MCS master ignition to v3_2 #4668
Conversation
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
live-iso is expected to fail till this one will be merged: For the same reason 🤷♂️ |
Can you help me find in the artifacts for the job where I can see the error causing the install to fail? Or is the job still not capturing adequate logs to show the failure? If we wait for openshift/assisted-test-infra#540 to merge, can we expect the job to pass for this PR? Or are they dependent such that both need to merge before the job will pass? |
|
I assume it should pass but I don't know for sure.
regarding logs, currently liveiso does not even boot since it gets 3.2.0
ignition on 4.6 rhcos so nothing cannot be done.
lets see what happens once test-infra merged. I'm interested as well.
I would not block on it at this point anyhow. but whatever you prefer.
…On Fri, Feb 19, 2021, 00:38 Matthew Staebler ***@***.***> wrote:
@staebler <https://github.com/staebler> @eranco74
<https://github.com/eranco74>
live-iso is expected to fail till this one will be merged:
openshift/assisted-test-infra#540
<openshift/assisted-test-infra#540>
For the same reason man_shrugging
Can you help me find in the artifacts for the job where I can see the
error causing the install to fail? Or is the job still not capturing
adequate logs to show the failure?
If we wait for openshift/assisted-test-infra#540
<openshift/assisted-test-infra#540> to merge, can
we expect the job to pass for this PR? Or are they dependent such that both
need to merge before the job will pass?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4668 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLPP45L43W2TACM4GW5RDDS7WJF3ANCNFSM4X2QYOCQ>
.
|
|
ok, after another thought, I don't understand how test infra can pass
without this one being merged.
so it would be great if you can merge once the required tests are done.
Thanks
…On Fri, Feb 19, 2021, 00:51 Rom Freiman ***@***.***> wrote:
I assume it should pass but I don't know for sure.
regarding logs, currently liveiso does not even boot since it gets 3.2.0
ignition on 4.6 rhcos so nothing cannot be done.
lets see what happens once test-infra merged. I'm interested as well.
I would not block on it at this point anyhow. but whatever you prefer.
On Fri, Feb 19, 2021, 00:38 Matthew Staebler ***@***.***>
wrote:
> @staebler <https://github.com/staebler> @eranco74
> <https://github.com/eranco74>
>
> live-iso is expected to fail till this one will be merged:
> openshift/assisted-test-infra#540
> <openshift/assisted-test-infra#540>
>
> For the same reason man_shrugging
>
> Can you help me find in the artifacts for the job where I can see the
> error causing the install to fail? Or is the job still not capturing
> adequate logs to show the failure?
>
> If we wait for openshift/assisted-test-infra#540
> <openshift/assisted-test-infra#540> to merge,
> can we expect the job to pass for this PR? Or are they dependent such that
> both need to merge before the job will pass?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#4668 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABLPP45L43W2TACM4GW5RDDS7WJF3ANCNFSM4X2QYOCQ>
> .
>
|
|
I have a couple of concerns.
|
|
/retest |
|
Regarding your concerns:
|
By now you should know that you need to discuss things with me multiple times for them to sink in. What specifically have we discussed in the past? I remember discussing that the installer CI jobs will not use the assisted installer. I do not recall discussing that the installer CI jobs will use the assisted-test-infra repo to perform the installation. I am not strictly opposed to that. It did came as a shock to me to see the use of a repo where the first line of the README states "[t]his project deploys the OpenShift Assisted Installer in Minikube [...]". It does concern me slightly that this is another installation mechanism that the installer team will need to have at least a passing understanding of in order to maintain the bootstrap-in-place functionality in the future. At this point, looking at the build logs and artifacts collected, I am ignorant about what the errors may have been that caused the test to fail. In any event, this discussion (while hopefully fruitful) is not really germane to this PR. /lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/e2e-ovirt The e2e-ovirt job is broken. The changes in this PR do not effect that job.. |
|
@staebler: Overrode contexts on behalf of staebler: ci/prow/e2e-ovirt In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
A recent PR bumped the ignition generated by the installer to v3.2.
This PR aligns the master ignition that bootstrap in place is getting from the machine config server to the same version.
This is mainly relevant for assisted-installer that might want to merge user custom Ignition (that should match the ignition version generated by the installer) with this ignition config.