Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NE-1790: Follow up to enable Dynamic Configuration Manager feature gate #1174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

NE-1790: Follow up to enable Dynamic Configuration Manager feature gate #1174

wants to merge 1 commit into from
+35 −23

Conversation

alebedev87
Copy link
Contributor

@alebedev87 alebedev87 commented Dec 18, 2024 •
edited
Loading

@alebedev87
NE-1790: Follow up to enable Dynamic Configuration Manager feature gate
9735e68 
- Ingress controller: passed reconciler config to `desiredRouterDeployment`.
- TestDesiredRouterDeploymentDynamicConfigManager: added test case for invalid max servers.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 18, 2024 •
edited by openshift-ci bot
Loading

@alebedev87: This pull request references NE-1790 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

  • Ingress controller: passed reconciler config to desiredRouterDeployment.
  • TestDesiredRouterDeploymentDynamicConfigManager: added test case for invalid max servers.

Follow-up to #1159.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from candita and rfredette December 18, 2024 13:31
@candita
Copy link
Contributor

candita commented Dec 18, 2024

/assign

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 18, 2024 •
edited by openshift-ci bot
Loading

@alebedev87: This pull request references NE-1790 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

  • Ingress controller: passed reconciler config to desiredRouterDeployment.
  • TestDesiredRouterDeploymentDynamicConfigManager: added test case for invalid max servers.

Follow-up to #1159:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@candita
Copy link
Contributor

candita commented Dec 19, 2024

Looks like unrelated failures:

Failed === RUN TestCreateClusterProxy/ValidateHostedCluster/EnsureNoCrashingPods
util.go:532: Container aws-ebs-csi-driver-operator in pod aws-ebs-csi-driver-operator-9f66975b8-8hvsx has a restartCount > 0 (1)
util.go:532: Container control-plane-operator in pod control-plane-operator-786f85d6fb-qbqhp has a restartCount > 0 (1)
--- FAIL: TestCreateClusterProxy/ValidateHostedCluster/EnsureNoCrashingPods (0.07s)

/test e2e-hypershift

@candita
Copy link
Contributor

candita commented Dec 19, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: candita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dbdff16 and 2 for PR HEAD 9735e68 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

@alebedev87: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 9735e68 link false /test e2e-aws-ovn-single-node
ci/prow/okd-scos-e2e-aws-ovn 9735e68 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-serial 9735e68 link unknown /test e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dbdff16 and 2 for PR HEAD 9735e68 in total

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@candita candita Awaiting requested review from candita

@rfredette rfredette Awaiting requested review from rfredette

Assignees

@candita candita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alebedev87 @openshift-ci-robot @candita