OCPBUGS-31550: Gateway API - recreating SMCP which breaks Gateway API

[anirudhAgniRedhat]

Recreating the SMCP and subscription, in case the SMCP or subscriptions are deleted manually.

[openshift-ci-robot]

@anirudhAgniRedhat: This pull request references Jira Issue OCPBUGS-31550, which is invalid:

• expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Recreating the SMCP and subscription, in case the SMCP or subscriptions are deleted manually.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[anirudhAgniRedhat]

/jira refresh

[openshift-ci-robot]

@anirudhAgniRedhat: This pull request references Jira Issue OCPBUGS-31550, which is invalid:

• expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[anirudhAgniRedhat]

/jira refresh

[openshift-ci-robot]

@anirudhAgniRedhat: This pull request references Jira Issue OCPBUGS-31550, which is invalid:

• expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[anirudhAgniRedhat]

/jira refresh

[openshift-ci-robot]

@anirudhAgniRedhat: This pull request references Jira Issue OCPBUGS-31550, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[anirudhAgniRedhat]

/hold
need to add watch

[rfredette]

Hmm, on my cluster, adding a watch for SMCPs when the operator starts is causing some issues.
The operator logs are hitting the error that the ServiceMeshControlPlane.maistra.io CRD doesn't exist:

2024-08-09T18:41:15.444Z ERROR operator.init.controller-runtime.source.EventHandler wait/loop.go:87 if kind is a CRD, it should be installed before calling Start{"kind": "ServiceMeshControlPlane.maistra.io", "error": "failed to get restmapping: no matches for kind \"ServiceMeshControlPlane\" in group \"maistra.io\""}

The OSSM operator installs the maistra.io CRDs, but because of this error, the gatewayclass controller never starts, and therefore it never creates the subscription for the OSSM operator.

We need to create the SMCP watch after the OSSM operator is installed. I messed around with the code and got a version where it seems to work. It may still need some polishing, but this is what I changed on my end: https://gist.github.com/rfredette/366a1f36ed4cf7425a5cc0f4ef270a24

[anirudhAgniRedhat]

@rfredette Added your suggestions Also added the watch to openshift-operator namespace as it was not reconciling on the given type.
PLMK if you think it should be done any other way??

[anirudhAgniRedhat]

/assign @candita

[anirudhAgniRedhat]

/retest

[candita]

/test e2e-aws-gatewayapi

[candita]

@anirudhAgniRedhat please add an e2e test for this to the existing e2e-aws-gatewayapi test.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from candita. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[anirudhAgniRedhat]

Hey @candita Added the e2e tests in testGatewayAPIIstioInstallation tests which is passing.
I think test testGatewayAPIObjects which is failing is irrespective of my change and is failing across different PRs.
PTAL Thanks!!

[gcs278]

DNS Propagation bug should be fixed, retesting gatewayapi:
/test e2e-aws-gatewayapi

[anirudhAgniRedhat]

Thanks @gcs278 for the update!!!
/test e2e-azure-ovn

[candita]

/assign @rfredette

[rhamini3]

pre-merge-verified

1. create the gatewayclass and gateway 
oc create -f -<<EOF
apiVersion: gateway.networking.k8s.io/v1beta1
kind: GatewayClass
metadata:
  name: openshift-default
spec:
  controllerName: openshift.io/gateway-controller
EOF

oc create -f - <<EOF
apiVersion: gateway.networking.k8s.io/v1beta1
kind: Gateway
metadata:
  name: gateway
  namespace: openshift-ingress
spec:
  gatewayClassName: openshift-default
  listeners:
  - name: http
    hostname: "*.$gwapi_domain"
    port: 80
    protocol: HTTP
    allowedRoutes:
      namespaces:
        from: All
  - name: https
    hostname: "*.$gwapi_domain"
    port: 443
    protocol: HTTPS
    tls:
      mode: Terminate
      certificateRefs:
      - name: gwapi-wildcard
    allowedRoutes:
      namespaces:
        from: All
EOF

2. Delete servicemeshcontrolplane and check if it is recreated % oc delete servicemeshcontrolplane openshift-gateway -n openshift-ingress servicemeshcontrolplane.maistra.io "openshift-gateway" deleted iamin@iamin-mac Downloads % oc get servicemeshcontrolplane --all-namespaces NAMESPACE NAME READY STATUS PROFILES VERSION AGE openshift-ingress openshift-gateway 5/5 ComponentsReady ["default"] 2.6.3 6s

3. create the HTTProute and check whether it is properly created and connected to the gateway
oc create -f - <<EOF                                               
apiVersion: gateway.networking.k8s.io/v1beta1
kind: HTTPRoute
metadata:
  name: myroute1
spec:
  parentRefs:
  - name: gateway
    namespace: openshift-ingress
  hostnames: ["test.$gwapi_domain"]
  rules:
  - backendRefs:
    - name: service-unsecure
      port: 27017
EOF
httproute.gateway.networking.k8s.io/myroute1 created

% oc get httproute myroute1 -oyaml
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  creationTimestamp: "2024-12-05T17:40:06Z"
  generation: 1
  name: myroute1
  namespace: default
  resourceVersion: "56779"
  uid: 1fc69414-c4ff-43d6-9dcb-61c3e6f552fb
spec:
  hostnames:
  - test.gwapi.ci-ln-xmn87rt-76ef8.aws-2.ci.openshift.org
  parentRefs:
  - group: gateway.networking.k8s.io
    kind: Gateway
    name: gateway
    namespace: openshift-ingress
  rules:
  - backendRefs:
    - group: ""
      kind: Service
      name: service-unsecure
      port: 27017
      weight: 1
    matches:
    - path:
        type: PathPrefix
        value: /
status:
  parents:
  - conditions:
    - lastTransitionTime: "2024-12-05T17:40:06Z"
      message: Route was valid, bound to 2 parents
      observedGeneration: 1
      reason: Accepted
      status: "True"
      type: Accepted
    - lastTransitionTime: "2024-12-05T17:40:06Z"
      message: All references resolved <--
      observedGeneration: 1
      reason: ResolvedRefs
      status: "True" <--
      type: ResolvedRefs
    controllerName: openshift.io/gateway-controller
    parentRef:
      group: gateway.networking.k8s.io
      kind: Gateway
      name: gateway
      namespace: openshift-ingress

Route is bound to the gateway and SMCP is recreated after controller reconciles
Mark as verified
/label qe-approved

[openshift-ci-robot]

@anirudhAgniRedhat: This pull request references Jira Issue OCPBUGS-31550, which is invalid:

• expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.17.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Recreating the SMCP and subscription, in case the SMCP or subscriptions are deleted manually.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[anirudhAgniRedhat]

/retest

[openshift-ci]

@anirudhAgniRedhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-gatewayapi	bd84ff9	link	false	/test e2e-aws-gatewayapi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[candita]

Why would we want to start a watch every time we reconcile?

[anirudhAgniRedhat]

Hey @candita, We are using sync.Once here, to start the watch for SMCP, which should run only once. So, this should not run on every reconciliation.

Since we need to create the SMCP watch after the OSSM operator is installed, we cannot start the watch as usual.