Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPLAT-1722: Remove alibaba #1111

Merged
merged 1 commit into from
Dec 18, 2024
Merged

SPLAT-1722: Remove alibaba #1111

merged 1 commit into from
Dec 18, 2024

Conversation

jcpowermac
Copy link
Contributor

@jcpowermac jcpowermac commented Jul 29, 2024 •
edited
Loading

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 29, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jcpowermac
Copy link
Contributor Author

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 29, 2024

@jcpowermac: The following commands are available to trigger required jobs:

  • /test e2e-aws-operator
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-serial
  • /test e2e-aws-ovn-upgrade
  • /test e2e-azure-operator
  • /test e2e-gcp-operator
  • /test e2e-hypershift
  • /test images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-aws-gatewayapi
  • /test e2e-aws-operator-techpreview
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-techpreview
  • /test e2e-azure-manual-oidc
  • /test e2e-azure-ovn
  • /test e2e-gcp-ovn
  • /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-gatewayapi
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-operator
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-operator-techpreview
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-serial
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-techpreview
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-azure-operator
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-azure-ovn
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-gcp-operator
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-gcp-ovn
  • pull-ci-openshift-cluster-ingress-operator-master-e2e-hypershift
  • pull-ci-openshift-cluster-ingress-operator-master-images
  • pull-ci-openshift-cluster-ingress-operator-master-unit
  • pull-ci-openshift-cluster-ingress-operator-master-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jcpowermac
Copy link
Contributor Author

/test e2e-aws-operator
/test e2e-aws-ovn

/test images
/test unit
/test verify

@jcpowermac jcpowermac changed the title Remove alibaba SPLAT-1722: Remove alibaba Jul 30, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 30, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 30, 2024 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-1722 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac jcpowermac marked this pull request as ready for review July 30, 2024 13:55
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2024
@openshift-ci openshift-ci bot requested review from candita and Thealisyed July 30, 2024 13:57
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2024
@alebedev87
Copy link
Contributor

/assign @gcs278

@alebedev87
Copy link
Contributor

@jcpowermac : Can you please provide a description of the change and more descriptive commit messages (with Jira ticket references)?

@alebedev87
Copy link
Contributor

/assign @grzpiotrowski

@Miciah Miciah added the priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. label Nov 13, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 18, 2024 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-1722 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR removes support for the Alibaba cloud
which is being removed from the product.

https://issues.redhat.com/browse/OCPSTRAT-1466
https://issues.redhat.com/browse/SPLAT-1454
https://issues.redhat.com//browse/SPLAT-1722

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 18, 2024 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-1722 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR removes support for the Alibaba cloud
which is being removed from the product.

https://issues.redhat.com/browse/OCPSTRAT-1466
https://issues.redhat.com/browse/SPLAT-1454
https://issues.redhat.com//browse/SPLAT-1722

Additional PRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac
Copy link
Contributor Author

@jcpowermac : Can you please provide a description of the change and more descriptive commit messages (with Jira ticket references)?

Sorry for the slow response...
Rebased, updated the commit and pr message.

@jcpowermac
Copy link
Contributor Author

@alebedev87 please let me know if there is something more that is needed.

@gcs278
Copy link
Contributor

gcs278 commented Dec 16, 2024

Seems straightforward enough. We still have an API field that has no fields within it, but as far as this PR is concerned, looks good to me.
/approve

@grzpiotrowski Do you want to take a look and LGTM?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gcs278

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
@grzpiotrowski
Copy link
Contributor

Checked for any potential leftovers and compared with the initial Alibaba PR.
Failed tests look unrelated.

/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
@gcs278
Copy link
Contributor

gcs278 commented Dec 17, 2024

Pod scheduling timeout
/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8be1749 and 2 for PR HEAD 42e6b19 in total

@gcs278
Copy link
Contributor

gcs278 commented Dec 18, 2024

infra failures
/retest

@grzpiotrowski
Copy link
Contributor 

{  openshift cluster install failed with infrastructure setup }

/retest

@gcs278
Copy link
Contributor

gcs278 commented Dec 18, 2024

Looks unrelated
/test e2e-aws-ovn-serial

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

@jcpowermac: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit dbdff16 into openshift:master Dec 18, 2024
18 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-ingress-operator
This PR has been included in build ose-cluster-ingress-operator-container-v4.19.0-202412190006.p0.gdbdff16.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@candita candita Awaiting requested review from candita

@Thealisyed Thealisyed Awaiting requested review from Thealisyed

Assignees

@gcs278 gcs278

@grzpiotrowski grzpiotrowski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jcpowermac @openshift-ci-robot @alebedev87 @gcs278 @grzpiotrowski @openshift-bot @Miciah @openshift-merge-robot