e2e: verify NROP machineconfigs are removed #1073
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rbaturov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
rbaturov
force-pushed
the
post-upgrade-test
branch
from
b569a7e
to
2e0b4df
Compare
rbaturov
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/retest-required |
| @@ -143,6 +144,21 @@ var _ = Describe("[Install] continuousIntegration", func() { | |||
| rteContainer, err := findContainerByName(*ds, containerNameRTE) | |||
| Expect(err).ToNot(HaveOccurred()) | |||
| Expect(rteContainer.SecurityContext.SELinuxOptions.Type).To(Equal(selinux.RTEContextType), "container %s is running with wrong selinux context", rteContainer.Name) | |||
|
|
|||
| By("checking numaresources machineconfigs removed when no SELinux policy annotation is present") | |||
There was a problem hiding this comment.
I think this test deserves to be running on a suite of its own which will be targeted for the an upgrade lane: openshift/release#58457
@ffromani WDYT?
test/e2e/install/install_test.go
Outdated
| Name: objectnames.GetMachineConfigName(updatedNROObj.Name, mcp.Name), | ||
| } | ||
| err := e2eclient.Client.Get(context.TODO(), mcKey, mc) | ||
| Expect(errors.IsNotFound(err)).To(BeTrue(), "MachineConfig %s is expected to not be found", mcKey.String()) |
There was a problem hiding this comment.
we are looking to find err !=nil too:
Expect(err).To(HaveOccurred())
let's also print out the error we got instead if it is other than NotFound
There was a problem hiding this comment.
Nice catch Shereen thanks
rbaturov
force-pushed
the
post-upgrade-test
branch
from
2e0b4df
to
b4ce63e
Compare
openshift-merge-robot
added
the
needs-rebase
rbaturov
force-pushed
the
post-upgrade-test
branch
from
b4ce63e
to
8da6754
Compare
Starting in version 4.18, NROP MachineConfigs containing the custom SELinux policy are expected to be removed unless a specific annotation is set in the NUMAResourcesOperator CR to enforce the use of the custom (legacy) SELinux policy. To ensure this behavior, we added a test that verifies MachineConfigs are removed when the annotation is absent in the CR. Signed-off-by: Ronny Baturov <[email protected]>
rbaturov
force-pushed
the
post-upgrade-test
branch
from
8da6754
to
e4fcfb7
Compare
openshift-merge-robot
removed
the
needs-rebase
Starting in version 4.18, NROP MachineConfigs containing the custom SELinux policy are expected to be removed unless a specific annotation is set in the NUMAResourcesOperator CR to enforce the use of the custom (legacy) SELinux policy. To ensure this behavior, we added a test that verifies MachineConfigs are removed when the annotation is absent in the CR.