sriov: Add WithRdmaMode method #790
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaskosk
reviewed
Nov 20, 2024
pkg/sriov/poolconfig.go
Outdated
| } | ||
|
|
||
| if mode == "" { | ||
| builder.errorMsg = "RdmaMode cannot be empty" |
There was a problem hiding this comment.
could you please add a glog statement to both of the mode check if statements? something like
glog.V(100).Info("PoolConfig RdmaMode cannot be empty")
pkg/sriov/poolconfig.go
Outdated
| } | ||
|
|
||
| if mode != "shared" && mode != "exclusive" { | ||
| builder.errorMsg = "Invalid value for rdmaMode. It should be 'shared' or 'exclusive'" |
There was a problem hiding this comment.
and for both of the error messages could you please change them to start with a lowercase letter?
Suggested change
| builder.errorMsg = "Invalid value for rdmaMode. It should be 'shared' or 'exclusive'" | |
| builder.errorMsg = "invalid value for rdmaMode. It should be 'shared' or 'exclusive'" |
ajaggapa
force-pushed
the
rdmamode
branch
3 times, most recently
from
3bd4056
to
fb25e1b
Compare
evgenLevin
reviewed
Nov 20, 2024
yprokule
reviewed
Nov 21, 2024
pkg/sriov/poolconfig.go
Outdated
| @@ -255,6 +255,33 @@ func (builder *PoolConfigBuilder) WithMaxUnavailable(maxUnavailable intstrutil.I | |||
| return builder | |||
| } | |||
|
|
|||
| // WithRdmaMode method sets rdmaMode to shared/exclusive. | |||
| func (builder *PoolConfigBuilder) WithRdmaMode(mode string) *PoolConfigBuilder { | |||
There was a problem hiding this comment.
nit: RDMA is acronym so worth using capital letters
Suggested change
| func (builder *PoolConfigBuilder) WithRdmaMode(mode string) *PoolConfigBuilder { | |
| func (builder *PoolConfigBuilder) WithRDMAMode(mode string) *PoolConfigBuilder { |
klaskosk
previously approved these changes
Nov 21, 2024
pkg/sriov/poolconfig_test.go
Outdated
| @@ -240,6 +240,40 @@ func TestWithMaxUnavailable(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestWithRdmaMode(t *testing.T) { | |||
There was a problem hiding this comment.
another nit, but this could be updated to match the capitalization of the function
Suggested change
| func TestWithRdmaMode(t *testing.T) { | |
| func TestWithRDMAMode(t *testing.T) { |
klaskosk
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.