Delete() funcs should return nil if not exists #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebrandon1
requested review from
trewest,
achuzhoy,
kononovn,
wabouhamad and
cdvultur
as code owners
sebrandon1
force-pushed
the
delete_returns
branch
6 times, most recently
from
1cdf551
to
7d29ff5
Compare
sebrandon1
force-pushed
the
delete_returns
branch
5 times, most recently
from
bc21dae
to
60b0b6f
Compare
sebrandon1
force-pushed
the
delete_returns
branch
4 times, most recently
from
c4915c4
to
cc36496
Compare
sebrandon1
force-pushed
the
delete_returns
branch
3 times, most recently
from
70a3569
to
d303184
Compare
sebrandon1
force-pushed
the
delete_returns
branch
4 times, most recently
from
f505182
to
00a350e
Compare
sebrandon1
force-pushed
the
delete_returns
branch
from
00a350e
to
c37e5bf
Compare
This was referenced Oct 16, 2024
sebrandon1
force-pushed
the
delete_returns
branch
from
7451b2b
to
ae53b9f
Compare
This was referenced Oct 21, 2024
sebrandon1
force-pushed
the
delete_returns
branch
from
ae53b9f
to
bc00764
Compare
This was referenced Oct 21, 2024
sebrandon1
force-pushed
the
delete_returns
branch
from
bc00764
to
e2f0eef
Compare
sebrandon1
force-pushed
the
delete_returns
branch
2 times, most recently
from
d125130
to
7c79708
Compare
sebrandon1
force-pushed
the
delete_returns
branch
from
7c79708
to
3498b15
Compare
sebrandon1
force-pushed
the
delete_returns
branch
from
3498b15
to
65ca88b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a mismatch of how we expect
Delete()funcs throughout the repo.The general consensus from most of the
Delete()functions is that we should return nil because the object doesn't exist. There are a few outliers that I changed in this PR that were returning an error because an item didn't exist.I have adjusted all of the Delete() funcs to set the
builder.Objectto nil and then returnnil