Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNF-15792: ztp: reference: Use capturegroupInlineDiff for PTPConfig [4.14] #2118

Open
wants to merge 1 commit into
base: release-4.14
Choose a base branch
from
Open

CNF-15792: ztp: reference: Use capturegroupInlineDiff for PTPConfig [4.14] #2118

wants to merge 1 commit into from

Conversation

lack
Copy link
Member

@lack lack commented Nov 22, 2024

This allows us to ignore customer-specified interfaces names in our PTP
configation testblobs, leading to better cluster-compare results.

Signed-off-by: Jim Ramsay [email protected]

@lack
ztp: reference: Use capturegroupInlineDiff for PTPConfig
8751d21 
This allows us to ignore customer-specified interfaces names in our PTP
configation testblobs, leading to better cluster-compare results.

Signed-off-by: Jim Ramsay <[email protected]>
@lack lack changed the title ztp: reference: Use capturegroupInlineDiff for PTPConfig CNF-15792: ztp: reference: Use capturegroupInlineDiff for PTPConfig [4.14] Nov 22, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 22, 2024
@openshift-ci-robot
Copy link
Collaborator

@lack: This pull request references CNF-15792 which is a valid jira issue.

In response to this:

This allows us to ignore customer-specified interfaces names in our PTP
configation testblobs, leading to better cluster-compare results.

Signed-off-by: Jim Ramsay [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenyis kenyis Awaiting requested review from kenyis

@SchSeba SchSeba Awaiting requested review from SchSeba

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lack @openshift-ci-robot