Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-44189: ztp: Fix workload partitioning annotation for LVM #2099

Conversation

imiller0
Copy link
Contributor

@imiller0 imiller0 commented Nov 4, 2024

The workload partitioning configuration is controlled by an annotation. Move the incorrect label to an annotation.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 4, 2024
@openshift-ci-robot
Copy link
Collaborator

@imiller0: This pull request references Jira Issue OCPBUGS-44189, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The workload partitioning configuration is controlled by an annotation. Move the incorrect label to an annotation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imiller0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
@imiller0
Copy link
Contributor Author

imiller0 commented Nov 4, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 4, 2024
@openshift-ci-robot
Copy link
Collaborator

@imiller0: This pull request references Jira Issue OCPBUGS-44189, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yliu127 November 4, 2024 15:01
The workload partitioning configuration is controlled by an annotation.
Move the incorrect label to an annotation.

Signed-off-by: Ian Miller <[email protected]>
@imiller0
Copy link
Contributor Author

imiller0 commented Nov 4, 2024

/test images

@sabbir-47
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit dc5b3fa into openshift-kni:master Nov 5, 2024
6 checks passed
@openshift-ci-robot
Copy link
Collaborator

@imiller0: Jira Issue OCPBUGS-44189: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44189 has been moved to the MODIFIED state.

In response to this:

The workload partitioning configuration is controlled by an annotation. Move the incorrect label to an annotation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@imiller0
Copy link
Contributor Author

imiller0 commented Nov 5, 2024

/cherry-pick release-4.17

@openshift-cherrypick-robot

@imiller0: new pull request created: #2100

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants