Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Run make generated-files #3052

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[main] Run make generated-files #3052

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

Generated by running make generated-files

@openshift-ci openshift-ci bot requested review from creydr and rhuss November 26, 2024 10:52
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a openshift-knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions github-actions bot force-pushed the auto/update-generated-files-main branch from 717e200 to 5e83b74 Compare November 26, 2024 11:18
creydr
creydr reviewed Nov 26, 2024
View reviewed changes
olm-catalog/serverless-operator-index/v4.17/catalog/serverless-operator/catalog.yaml Outdated
image: registry.redhat.io/openshift-serverless-1/serverless-operator-bundle@sha256:0d5feb3c9f59246d16db1c687e3c1085fcc8a360cd51974197a878944df06b1d
image: quay.io/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-135/serverless-bundle@sha256:f4f26ea2db068487bc81d657cd28b16d8e352cff74b8d9ca6415403b198a88ed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgencur @pierDipi do you know, why we switch from registry.redhat.io to quay?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't know, this part is very unclear to me how it works

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generating script probably needs a fix. This should now point to serverless-operator-136, not serverless-operator-135

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump didn't go through yet so that's why it's sill 1.35 ? #3060

@github-actions github-actions bot force-pushed the auto/update-generated-files-main branch 9 times, most recently from 63f4d73 to 5c4171a Compare November 29, 2024 09:04
@skonto
Copy link
Contributor

skonto commented Nov 29, 2024

Should we merge this one?

@github-actions github-actions bot force-pushed the auto/update-generated-files-main branch 7 times, most recently from e688ac9 to 4b051ef Compare December 4, 2024 06:46
@github-actions github-actions bot force-pushed the auto/update-generated-files-main branch from 4b051ef to 3ecca8b Compare December 11, 2024 13:41
@github-actions github-actions bot force-pushed the auto/update-generated-files-main branch from 3ecca8b to be59c01 Compare December 12, 2024 06:48
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: github-actions[bot]
Once this PR has been reviewed and has the lgtm label, please assign mgencur for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot force-pushed the auto/update-generated-files-main branch 2 times, most recently from 2c45625 to 3d3ec7c Compare December 12, 2024 10:37
@github-actions github-actions bot force-pushed the auto/update-generated-files-main branch 11 times, most recently from 28f4ec6 to 8df41fe Compare December 19, 2024 06:57
@github-actions github-actions bot force-pushed the auto/update-generated-files-main branch 2 times, most recently from b6ee4a3 to 3c91796 Compare December 21, 2024 06:43
@github-actions github-actions bot force-pushed the auto/update-generated-files-main branch 6 times, most recently from d121966 to 8ea0675 Compare January 10, 2025 06:46
@github-actions github-actions bot force-pushed the auto/update-generated-files-main branch from 8ea0675 to 67e5276 Compare January 12, 2025 06:42
@mvinkler mvinkler mentioned this pull request Jan 13, 2025
Open
@github-actions github-actions bot force-pushed the auto/update-generated-files-main branch from 67e5276 to 1806516 Compare January 14, 2025 06:49
@github-actions github-actions bot force-pushed the auto/update-generated-files-main branch from 1806516 to 95643c0 Compare January 15, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi left review comments

@creydr creydr creydr left review comments

@mgencur mgencur mgencur left review comments

@rhuss rhuss Awaiting requested review from rhuss

Assignees
No one assigned
Labels
needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skonto @mgencur @creydr @pierDipi @openshift-merge-robot