Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get source rpm from purl #1096

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

thegreyd
Copy link
Contributor

@thegreyd thegreyd commented Oct 29, 2024

We rely on "syft:metadata:sourceRpm" which is generated by syft, the cli tool konflux uses to generate sbom.
It is not the official identifier in the sbom spec, it can go away if another tool is used.
Instead rely on purl which is the identifier in the sbom spec
https://cyclonedx.org/docs/1.6/json/#components_items_purl
Use https://github.com/package-url/packageurl-python to parse purl

Note: https://cyclonedx-python-library.readthedocs.io/en/latest/schema-support.html is a nice lib to
work with the whole sbom, but lacks support for some schema keys in the latest version which konflux uses.

@thegreyd
Copy link
Contributor Author

thegreyd commented Oct 29, 2024

/hold
Need to test.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2024
Copy link
Contributor

openshift-ci bot commented Oct 29, 2024

@thegreyd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 8020d67 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vfreex
Copy link
Contributor

vfreex commented Oct 30, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2024
Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vfreex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants