Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for dev container artcd / elliot config files #1026

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix for dev container artcd / elliot config files #1026

wants to merge 1 commit into from

Conversation

lgarciaaco
Copy link
Contributor

No description provided.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lgarciaaco. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 10, 2024

@lgarciaaco: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security f16e570 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

vfreex
vfreex reviewed Oct 15, 2024
View reviewed changes
.devcontainer/artcd.settings.yaml
Comment on lines +15 to +18
qe_notification_recipients_ocp4=["[email protected]"]
qe_notification_recipients_ocp3=["[email protected]"]
promote_image_list_recipients = ["[email protected]"]
promote_complete_recipients = ['[email protected]']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting a personal email address here seems concerning. Maybe keep them empty?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfreex vfreex vfreex left review comments

Assignees

@Ximinhan Ximinhan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lgarciaaco @vfreex @Ximinhan