-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for unsupported type/identifier/commands #3195
Conversation
Signed-off-by: Tomoyuki Morita <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious if it's defined as unsupported in grammar for all data sources, why we still want them in grammar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ykmr1224
can we auto-generate the SQLGrammarElement
& PPLGrammarElement
automatically using the ANTLR files ?
Those are coming from Spark SQL grammar, which we don't want to touch considering when we upgrade Spark version. |
I considered that option initially, but the grammar file contains lots of elements, where same grammar element can be define as multiple way in g4 file. That could lead to very redundant configuration. Also the error message would need to use node name in g4 file, which would become very unclear for users. |
Signed-off-by: Tomoyuki Morita <[email protected]> (cherry picked from commit 8bfa2e9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 8bfa2e9) Signed-off-by: Tomoyuki Morita <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Related Issues
#3185
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.