-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Array values are preserved (#1300) (#3095) #3120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penghuo
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG and
ykmr1224
as code owners
October 25, 2024 00:37
…ect#3095) Signed-off-by: Norman Jordan <[email protected]> (cherry picked from commit e109417)
penghuo
force-pushed
the
backport-3095-to-2.x
branch
from
October 25, 2024 01:59
b101b6a
to
7ef1071
Compare
penghuo
changed the title
[Backport] Array values are preserved (#1300) (#3095)
[Backport 2.x] Array values are preserved (#1300) (#3095)
Oct 25, 2024
Upload Artifacts failed, ready to merge. |
noCharger
approved these changes
Oct 25, 2024
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.15 2.15
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.15
# Create a new branch
git switch --create backport/backport-3120-to-2.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 81577dfc8035a1baf0751e87e3ac98736021c5dd
# Push it to GitHub
git push --set-upstream origin backport/backport-3120-to-2.15
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.15 Then, create a pull request where the |
noCharger
pushed a commit
to noCharger/sql
that referenced
this pull request
Oct 25, 2024
…ect#3095) (opensearch-project#3120) Signed-off-by: Norman Jordan <[email protected]> (cherry picked from commit e109417) Co-authored-by: normanj-bitquill <[email protected]>
noCharger
pushed a commit
to noCharger/sql
that referenced
this pull request
Oct 25, 2024
…ect#3095) (opensearch-project#3120) Signed-off-by: Norman Jordan <[email protected]> (cherry picked from commit e109417) Co-authored-by: normanj-bitquill <[email protected]> Signed-off-by: Louis Chu <[email protected]>
noCharger
pushed a commit
to noCharger/sql
that referenced
this pull request
Oct 26, 2024
…ect#3095) (opensearch-project#3120) Signed-off-by: Norman Jordan <[email protected]> (cherry picked from commit e109417) Co-authored-by: normanj-bitquill <[email protected]> Signed-off-by: Louis Chu <[email protected]>
noCharger
pushed a commit
to noCharger/sql
that referenced
this pull request
Oct 26, 2024
…ect#3095) (opensearch-project#3120) Signed-off-by: Norman Jordan <[email protected]> (cherry picked from commit e109417) Co-authored-by: normanj-bitquill <[email protected]> Signed-off-by: Louis Chu <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
Signed-off-by: Norman Jordan <[email protected]> (cherry picked from commit e109417) Co-authored-by: normanj-bitquill <[email protected]> (cherry picked from commit 81577df) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
penghuo
pushed a commit
that referenced
this pull request
Oct 30, 2024
(cherry picked from commit e109417) (cherry picked from commit 81577df) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: normanj-bitquill <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Norman Jordan [email protected]
(cherry picked from commit e109417)
Description
Backport. #3095
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.