-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable PPL lang and add datasource to async query API #2187
Merged
vmmusings
merged 1 commit into
opensearch-project:main
from
vmmusings:enable-ppl-datasource
Oct 3, 2023
Merged
Enable PPL lang and add datasource to async query API #2187
vmmusings
merged 1 commit into
opensearch-project:main
from
vmmusings:enable-ppl-datasource
Oct 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmmusings
force-pushed
the
enable-ppl-datasource
branch
from
October 2, 2023 20:33
26dab6c
to
fc7ec43
Compare
Codecov Report
@@ Coverage Diff @@
## main #2187 +/- ##
============================================
- Coverage 96.56% 96.55% -0.02%
+ Complexity 4717 4715 -2
============================================
Files 436 436
Lines 12535 12526 -9
Branches 858 856 -2
============================================
- Hits 12105 12094 -11
- Misses 420 422 +2
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
vmmusings
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
October 2, 2023 20:51
penghuo
reviewed
Oct 2, 2023
spark/src/main/java/org/opensearch/sql/spark/rest/model/CreateAsyncQueryRequest.java
Show resolved
Hide resolved
spark/src/main/java/org/opensearch/sql/spark/dispatcher/SparkQueryDispatcher.java
Show resolved
Hide resolved
spark/src/main/java/org/opensearch/sql/spark/dispatcher/SparkQueryDispatcher.java
Outdated
Show resolved
Hide resolved
penghuo
previously approved these changes
Oct 3, 2023
Signed-off-by: Vamsi Manohar <[email protected]>
vmmusings
force-pushed
the
enable-ppl-datasource
branch
from
October 3, 2023 01:52
fc7ec43
to
eb0aabe
Compare
penghuo
approved these changes
Oct 3, 2023
YANG-DB
approved these changes
Oct 3, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit ea2ed26) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vmmusings
pushed a commit
that referenced
this pull request
Oct 3, 2023
(cherry picked from commit ea2ed26) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.