-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CreateAlertTool #349
Merged
xinyual
merged 12 commits into
opensearch-project:main
from
qianheng-aws:qianheng/alertTool
Aug 1, 2024
Merged
add CreateAlertTool #349
xinyual
merged 12 commits into
opensearch-project:main
from
qianheng-aws:qianheng/alertTool
Aug 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qianheng-aws
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90,
zhichao-aws and
joshuali925
as code owners
July 12, 2024 13:20
xinyual
reviewed
Jul 12, 2024
xinyual
reviewed
Jul 12, 2024
@qianheng-aws please run |
qianheng-aws
force-pushed
the
qianheng/alertTool
branch
from
July 25, 2024 05:44
631cf10
to
e287b50
Compare
Signed-off-by: Heng Qian <[email protected]>
Signed-off-by: Heng Qian <[email protected]>
Signed-off-by: Heng Qian <[email protected]>
Signed-off-by: Heng Qian <[email protected]>
Signed-off-by: Heng Qian <[email protected]>
Signed-off-by: Heng Qian <[email protected]>
qianheng-aws
force-pushed
the
qianheng/alertTool
branch
from
July 25, 2024 05:54
e287b50
to
1351b5b
Compare
Signed-off-by: Heng Qian <[email protected]>
Signed-off-by: Heng Qian <[email protected]>
zane-neo
reviewed
Jul 25, 2024
zane-neo
reviewed
Jul 25, 2024
zane-neo
reviewed
Jul 25, 2024
zane-neo
reviewed
Jul 25, 2024
zane-neo
reviewed
Jul 25, 2024
zane-neo
reviewed
Jul 25, 2024
Signed-off-by: Heng Qian <[email protected]>
Signed-off-by: Heng Qian <[email protected]>
Signed-off-by: Heng Qian <[email protected]>
zane-neo
approved these changes
Jul 29, 2024
xinyual
reviewed
Jul 29, 2024
Signed-off-by: Heng Qian <[email protected]>
xinyual
approved these changes
Aug 1, 2024
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/skills/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/skills/backport-2.x
# Create a new branch
git switch --create backport/backport-349-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 798065f7e945b0569c89d003776c147dc6722723
# Push it to GitHub
git push --set-upstream origin backport/backport-349-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/skills/backport-2.x Then, create a pull request where the |
qianheng-aws
added a commit
to qianheng-aws/skills
that referenced
this pull request
Oct 31, 2024
* add CreateAlertTool Signed-off-by: Heng Qian <[email protected]> * spotlessApply and address comments Signed-off-by: Heng Qian <[email protected]> * add IT for CreateAlertTool Signed-off-by: Heng Qian <[email protected]> * address comments Signed-off-by: Heng Qian <[email protected]> * fix after merging main Signed-off-by: Heng Qian <[email protected]> * fix forbidden API Signed-off-by: Heng Qian <[email protected]> * fix IT failure Signed-off-by: Heng Qian <[email protected]> * run spotlessCheck Signed-off-by: Heng Qian <[email protected]> * Address comments Signed-off-by: Heng Qian <[email protected]> * Address comments of changing getIndex to use ActionListener Signed-off-by: Heng Qian <[email protected]> * fix IT Signed-off-by: Heng Qian <[email protected]> * make prompt dict static Signed-off-by: Heng Qian <[email protected]> --------- Signed-off-by: Heng Qian <[email protected]>
qianheng-aws
added a commit
to qianheng-aws/skills
that referenced
this pull request
Oct 31, 2024
* add CreateAlertTool Signed-off-by: Heng Qian <[email protected]> * spotlessApply and address comments Signed-off-by: Heng Qian <[email protected]> * add IT for CreateAlertTool Signed-off-by: Heng Qian <[email protected]> * address comments Signed-off-by: Heng Qian <[email protected]> * fix after merging main Signed-off-by: Heng Qian <[email protected]> * fix forbidden API Signed-off-by: Heng Qian <[email protected]> * fix IT failure Signed-off-by: Heng Qian <[email protected]> * run spotlessCheck Signed-off-by: Heng Qian <[email protected]> * Address comments Signed-off-by: Heng Qian <[email protected]> * Address comments of changing getIndex to use ActionListener Signed-off-by: Heng Qian <[email protected]> * fix IT Signed-off-by: Heng Qian <[email protected]> * make prompt dict static Signed-off-by: Heng Qian <[email protected]> --------- Signed-off-by: Heng Qian <[email protected]>
5 tasks
zane-neo
added a commit
that referenced
this pull request
Nov 14, 2024
* add CreateAlertTool (#349) * add CreateAlertTool Signed-off-by: Heng Qian <[email protected]> * spotlessApply and address comments Signed-off-by: Heng Qian <[email protected]> * add IT for CreateAlertTool Signed-off-by: Heng Qian <[email protected]> * address comments Signed-off-by: Heng Qian <[email protected]> * fix after merging main Signed-off-by: Heng Qian <[email protected]> * fix forbidden API Signed-off-by: Heng Qian <[email protected]> * fix IT failure Signed-off-by: Heng Qian <[email protected]> * run spotlessCheck Signed-off-by: Heng Qian <[email protected]> * Address comments Signed-off-by: Heng Qian <[email protected]> * Address comments of changing getIndex to use ActionListener Signed-off-by: Heng Qian <[email protected]> * fix IT Signed-off-by: Heng Qian <[email protected]> * make prompt dict static Signed-off-by: Heng Qian <[email protected]> --------- Signed-off-by: Heng Qian <[email protected]> * Fix gradle task forbiddenApisMain failure (#391) * Fix gradle task forbiddenApisMain failure Signed-off-by: zane-neo <[email protected]> * fix compilation error since AD change Signed-off-by: zane-neo <[email protected]> --------- Signed-off-by: zane-neo <[email protected]> (cherry picked from commit 3e63a62) Signed-off-by: Heng Qian <[email protected]> --------- Signed-off-by: Heng Qian <[email protected]> Signed-off-by: zane-neo <[email protected]> Co-authored-by: zane-neo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementing CreateAlertTool, which aims to help create alert with natural language. The tool has 3 input parameters:
This tool is able to request LLM by itself and has its own tool prompt, and it can also get some necessary information by calling OS API.
When this tool is selected by chat agent or invoked by flow agent, it will be executed as following steps:
The tool output format may be like:
Note: it relies on ChatAgentRunner to pass chat_history to this tool, so it needs to add a new method in Tool interface and override it, as explained in this issue #2645
There is a demo video about creating an alert by LLM: https://broadcast.amazon.com/videos/1159580
Related Issues
Resolves #[338]
Has dependency on this issue in ml-commons repo: #2645
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.