Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Bug] Add exists check for IOCs index. #1394

Merged
merged 1 commit into from
Oct 25, 2024
Merged

[Backport 2.x] [Bug] Add exists check for IOCs index. #1394

merged 1 commit into from
Oct 25, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 4432b36 from #1392.

@github-actions
[Bug] Add exists check for IOCs index. (#1392)
902082f 
* Added check to prevent resource_already_exists_exception when indexing more than 10k iocs.

Signed-off-by: AWSHurneyt <[email protected]>

* Changed log message.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit 4432b36)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov Codecov
Copy link

codecov bot commented Oct 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.16%. Comparing base (8077fc7) to head (902082f).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../securityanalytics/services/STIX2IOCFeedStore.java 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x    #1394      +/-   ##
============================================
+ Coverage     69.00%   69.16%   +0.15%     
- Complexity     3606     3608       +2     
============================================
  Files           405      405              
  Lines         20122    20126       +4     
  Branches       2046     2046              
============================================
+ Hits          13886    13920      +34     
+ Misses         5213     5182      -31     
- Partials       1023     1024       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AWSHurneyt AWSHurneyt merged commit 7c9792a into 2.x Oct 25, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jowg-amazon jowg-amazon jowg-amazon approved these changes

@AWSHurneyt AWSHurneyt AWSHurneyt approved these changes

@amsiglan amsiglan Awaiting requested review from amsiglan amsiglan is a code owner

@getsaurabh02 getsaurabh02 Awaiting requested review from getsaurabh02 getsaurabh02 is a code owner

@lezzago lezzago Awaiting requested review from lezzago lezzago is a code owner

@praveensameneni praveensameneni Awaiting requested review from praveensameneni praveensameneni is a code owner

@sbcd90 sbcd90 Awaiting requested review from sbcd90 sbcd90 is a code owner

@eirsep eirsep Awaiting requested review from eirsep eirsep is a code owner

@engechas engechas Awaiting requested review from engechas engechas is a code owner

@goyamegh goyamegh Awaiting requested review from goyamegh goyamegh is a code owner

@riysaxen-amzn riysaxen-amzn Awaiting requested review from riysaxen-amzn riysaxen-amzn is a code owner

Assignees
No one assigned
Labels
autocut
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AWSHurneyt @jowg-amazon