Add validation for threat intel source config #1393
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,7 +24,19 @@ public class SourceConfigDtoValidator { | |
| public List<String> validateSourceConfigDto(SATIFSourceConfigDto sourceConfigDto) { | ||
| List<String> errorMsgs = new ArrayList<>(); | ||
|
|
||
| if (sourceConfigDto.getName() == null || sourceConfigDto.getName().isEmpty()) { | ||
|
There was a problem hiding this comment. @jowg-amazon could we add length restrictions? The frontend uses this validation for names. There was a problem hiding this comment. added validation for names based on how frontend currently validates the name |
||
| errorMsgs.add("Name must not be empty"); | ||
| } | ||
|
|
||
| if (sourceConfigDto.getFormat() == null || sourceConfigDto.getFormat().isEmpty()) { | ||
|
There was a problem hiding this comment. We may need to add length validation for this as well. Unless this gets validated somewhere downstream, the config could be created via backend API with something like 300k characters; which could disrupt functionality. There was a problem hiding this comment. Added length validation |
||
| errorMsgs.add("Format must not be empty"); | ||
| } | ||
|
|
||
| if (sourceConfigDto.getSource() == null) { | ||
| errorMsgs.add("Source must not be empty"); | ||
| } | ||
|
|
||
| if (sourceConfigDto.getIocTypes() == null || sourceConfigDto.getIocTypes().isEmpty()) { | ||
| errorMsgs.add("Must specify at least one IOC type"); | ||
| } else { | ||
| for (String s: sourceConfigDto.getIocTypes()) { | ||
|
|
@@ -34,34 +46,41 @@ public List<String> validateSourceConfigDto(SATIFSourceConfigDto sourceConfigDto | |
| } | ||
| } | ||
|
|
||
| if (sourceConfigDto.getType() == null) { | ||
| errorMsgs.add("Type must not be empty"); | ||
| } else { | ||
| switch (sourceConfigDto.getType()) { | ||
| case IOC_UPLOAD: | ||
| if (sourceConfigDto.isEnabled()) { | ||
| errorMsgs.add("Job Scheduler cannot be enabled for IOC_UPLOAD type"); | ||
| } | ||
| if (sourceConfigDto.getSchedule() != null) { | ||
| errorMsgs.add("Cannot pass in schedule for IOC_UPLOAD type"); | ||
| } | ||
| if (sourceConfigDto.getSource() != null && sourceConfigDto.getSource() instanceof IocUploadSource == false) { | ||
| errorMsgs.add("Source must be IOC_UPLOAD type"); | ||
| } | ||
| if (sourceConfigDto.getSource() instanceof IocUploadSource && ((IocUploadSource) sourceConfigDto.getSource()).getIocs() == null) { | ||
| errorMsgs.add("Ioc list must include at least one ioc"); | ||
| } | ||
| break; | ||
| case S3_CUSTOM: | ||
| if (sourceConfigDto.getSchedule() == null) { | ||
| errorMsgs.add("Must pass in schedule for S3_CUSTOM type"); | ||
| } | ||
| if (sourceConfigDto.getSource() != null && sourceConfigDto.getSource() instanceof S3Source == false) { | ||
| errorMsgs.add("Source must be S3_CUSTOM type"); | ||
| } | ||
| break; | ||
| case URL_DOWNLOAD: | ||
| if (sourceConfigDto.getSchedule() == null) { | ||
| errorMsgs.add("Must pass in schedule for URL_DOWNLOAD source type"); | ||
| } | ||
| if (sourceConfigDto.getSource() != null && sourceConfigDto.getSource() instanceof UrlDownloadSource == false) { | ||
| errorMsgs.add("Source must be URL_DOWNLOAD source type"); | ||
| } | ||
| break; | ||
| } | ||
| } | ||
| return errorMsgs; | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a follow-up item, let's add validation for the refresh frequency.