Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fixed ListIOCs number of findings cap. #1373

Merged
merged 4 commits into from
Oct 23, 2024
Merged

[Bug] Fixed ListIOCs number of findings cap. #1373

merged 4 commits into from
Oct 23, 2024

Conversation

AWSHurneyt
Copy link
Collaborator

Description

  1. Fixed total IOCs count capping at 10,000.
  2. Fixed number of findings per IOC capping at 10,000.

Related Issues

Resolves #1191

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AWSHurneyt AWSHurneyt marked this pull request as ready for review October 23, 2024 17:04
@AWSHurneyt
Copy link
Collaborator Author

The security test workflow has been failing (example), and will be investigated separately.

jowg-amazon
jowg-amazon previously approved these changes Oct 23, 2024
View reviewed changes
@AWSHurneyt AWSHurneyt merged commit d5c8f7a into opensearch-project:main Oct 23, 2024
8 of 9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 23, 2024
@github-actions
[Bug] Fixed ListIOCs number of findings cap. (#1373)
12ccb97 
* Fixed finding number returned by ListIOCs API capping at 10,000.

Signed-off-by: AWSHurneyt <[email protected]>

* Added integ test for fix.

Signed-off-by: AWSHurneyt <[email protected]>

* Removed extraneous query params.

Signed-off-by: AWSHurneyt <[email protected]>

* Added additional test case.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit d5c8f7a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 23, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 23, 2024
@github-actions
[Bug] Fixed ListIOCs number of findings cap. (#1373)
7f89665 
* Fixed finding number returned by ListIOCs API capping at 10,000.

Signed-off-by: AWSHurneyt <[email protected]>

* Added integ test for fix.

Signed-off-by: AWSHurneyt <[email protected]>

* Removed extraneous query params.

Signed-off-by: AWSHurneyt <[email protected]>

* Added additional test case.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit d5c8f7a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 23, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 23, 2024
@github-actions
[Bug] Fixed ListIOCs number of findings cap. (#1373)
efe8bfb 
* Fixed finding number returned by ListIOCs API capping at 10,000.

Signed-off-by: AWSHurneyt <[email protected]>

* Added integ test for fix.

Signed-off-by: AWSHurneyt <[email protected]>

* Removed extraneous query params.

Signed-off-by: AWSHurneyt <[email protected]>

* Added additional test case.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit d5c8f7a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 23, 2024
Open
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 23, 2024
@github-actions
[Bug] Fixed ListIOCs number of findings cap. (#1373)
633a4b0 
* Fixed finding number returned by ListIOCs API capping at 10,000.

Signed-off-by: AWSHurneyt <[email protected]>

* Added integ test for fix.

Signed-off-by: AWSHurneyt <[email protected]>

* Removed extraneous query params.

Signed-off-by: AWSHurneyt <[email protected]>

* Added additional test case.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit d5c8f7a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 23, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 23, 2024
@github-actions
[Bug] Fixed ListIOCs number of findings cap. (#1373)
c079acc 
* Fixed finding number returned by ListIOCs API capping at 10,000.

Signed-off-by: AWSHurneyt <[email protected]>

* Added integ test for fix.

Signed-off-by: AWSHurneyt <[email protected]>

* Removed extraneous query params.

Signed-off-by: AWSHurneyt <[email protected]>

* Added additional test case.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit d5c8f7a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 23, 2024
Merged
AWSHurneyt pushed a commit that referenced this pull request Oct 23, 2024
@opensearch-trigger-bot @github-actions
[Bug] Fixed ListIOCs number of findings cap. (#1373) (#1378)
448f37e 
* Fixed finding number returned by ListIOCs API capping at 10,000.



* Added integ test for fix.



* Removed extraneous query params.



* Added additional test case.



---------


(cherry picked from commit d5c8f7a)

Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt pushed a commit that referenced this pull request Oct 23, 2024
@opensearch-trigger-bot @github-actions
[Bug] Fixed ListIOCs number of findings cap. (#1373) (#1380)
cddadc7 
* Fixed finding number returned by ListIOCs API capping at 10,000.



* Added integ test for fix.



* Removed extraneous query params.



* Added additional test case.



---------


(cherry picked from commit d5c8f7a)

Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt pushed a commit that referenced this pull request Oct 23, 2024
@opensearch-trigger-bot @github-actions
[Bug] Fixed ListIOCs number of findings cap. (#1373) (#1381)
a1f7ec3 
* Fixed finding number returned by ListIOCs API capping at 10,000.



* Added integ test for fix.



* Removed extraneous query params.



* Added additional test case.



---------


(cherry picked from commit d5c8f7a)

Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt pushed a commit that referenced this pull request Oct 23, 2024
@opensearch-trigger-bot @github-actions
[Bug] Fixed ListIOCs number of findings cap. (#1373) (#1377)
3de58c5 
* Fixed finding number returned by ListIOCs API capping at 10,000.



* Added integ test for fix.



* Removed extraneous query params.



* Added additional test case.



---------


(cherry picked from commit d5c8f7a)

Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jowg-amazon jowg-amazon jowg-amazon approved these changes

@eirsep eirsep eirsep approved these changes

@amsiglan amsiglan Awaiting requested review from amsiglan amsiglan is a code owner

@getsaurabh02 getsaurabh02 Awaiting requested review from getsaurabh02 getsaurabh02 is a code owner

@lezzago lezzago Awaiting requested review from lezzago lezzago is a code owner

@praveensameneni praveensameneni Awaiting requested review from praveensameneni praveensameneni is a code owner

@sbcd90 sbcd90 Awaiting requested review from sbcd90 sbcd90 is a code owner

@engechas engechas Awaiting requested review from engechas engechas is a code owner

@goyamegh goyamegh Awaiting requested review from goyamegh goyamegh is a code owner

@riysaxen-amzn riysaxen-amzn Awaiting requested review from riysaxen-amzn riysaxen-amzn is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.15 backport 2.16 backport 2.17 backport 2.18
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] ListIOCsAPI total hits, and findings count per IOC are incorrect
3 participants
@AWSHurneyt @eirsep @jowg-amazon