secure rest tests for threat intel monitor apis #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirsep
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
jowg-amazon,
engechas,
goyamegh and
riysaxen-amzn
as code owners
eirsep
force-pushed
the
threat-intel-monitor-secure-tests
branch
2 times, most recently
from
003a400 to
30398db
Compare
jowg-amazon
reviewed
Aug 5, 2024
|
|
||
| static String TEST_IT_BACKEND_ROLE = "IT"; | ||
|
|
||
| static Map<String, String> roleToPermissionsMap = Map.ofEntries( |
| ); | ||
|
|
||
| private RestClient userClient; | ||
| private final String user = "userDetector"; |
There was a problem hiding this comment.
nit: rename from detectore
AWSHurneyt
reviewed
Aug 6, 2024
| deleteUser(user); | ||
| } | ||
|
|
||
| private final String iocIndexMappings = "\"properties\": {\n" + |
There was a problem hiding this comment.
Wondering if there's a better way to go about getting the mappings for an index; I think we're essentially copying the mappings for a couple of tests. Perhaps a helper method that can get the mappings from the json resource files, and extract out just the properties?
Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
eirsep
force-pushed
the
threat-intel-monitor-secure-tests
branch
from
30398db to
1bbb0ae
Compare
jowg-amazon
approved these changes
Aug 9, 2024
AWSHurneyt
approved these changes
Aug 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 3, 2024
* secure tests for threat intel monitor apis Signed-off-by: Surya Sashank Nistala <[email protected]> * address review comments Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 15b40db) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds secure rest tests for threat intel monitor APIs
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.