Skip to content

Commit

Permalink
Fix threat intel multinode tests (#1274)
Browse files Browse the repository at this point in the history
* fix multinode tests

Signed-off-by: Joanne Wang <[email protected]>

* fix multinode

Signed-off-by: Joanne Wang <[email protected]>

---------

Signed-off-by: Joanne Wang <[email protected]>
(cherry picked from commit f89c3ed)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
github-actions[bot] committed Sep 4, 2024
1 parent baa25a8 commit c238362
Showing 1 changed file with 15 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import org.apache.logging.log4j.Logger;
import org.opensearch.OpenSearchException;
import org.opensearch.action.DocWriteRequest;
import org.opensearch.action.StepListener;
import org.opensearch.action.admin.indices.create.CreateIndexRequest;
import org.opensearch.action.admin.indices.create.CreateIndexResponse;
import org.opensearch.action.bulk.BulkRequest;
Expand Down Expand Up @@ -80,7 +81,6 @@ public STIX2IOCFeedStore(
this.baseListener = listener;
batchSize = clusterService.getClusterSettings().get(SecurityAnalyticsSettings.BATCH_SIZE);
newActiveIndex = getNewActiveIndex(saTifSourceConfig.getId());
initSourceConfigIndexes();
}

@Override
Expand Down Expand Up @@ -113,7 +113,15 @@ public void storeIOCs(Map<IOC, UpdateAction> actionToIOCs) {
}

public void indexIocs(List<STIX2IOC> iocs) throws IOException {
bulkIndexIocs(iocs, newActiveIndex);
StepListener<Void> initSourceConfigIndexesListener = new StepListener<>();
initSourceConfigIndexes(initSourceConfigIndexesListener);
initSourceConfigIndexesListener.whenComplete(r -> {
bulkIndexIocs(iocs, newActiveIndex);
}, e -> {
log.error("Failed to init source config indexes");
baseListener.onFailure(e);
});

Check warning on line 123 in src/main/java/org/opensearch/securityanalytics/services/STIX2IOCFeedStore.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/org/opensearch/securityanalytics/services/STIX2IOCFeedStore.java#L121-L123

Added lines #L121 - L123 were not covered by tests

}

private void bulkIndexIocs(List<STIX2IOC> iocs, String activeIndex) throws IOException {
Expand Down Expand Up @@ -197,7 +205,7 @@ public SATIFSourceConfig getSaTifSourceConfig() {
return saTifSourceConfig;
}

private void initSourceConfigIndexes() {
private void initSourceConfigIndexes(StepListener<Void> stepListener) {
String iocIndexPattern = getAllIocIndexPatternById(saTifSourceConfig.getId());
initFeedIndex(newActiveIndex, ActionListener.wrap(
r -> {
Expand All @@ -214,10 +222,10 @@ private void initSourceConfigIndexes() {
((DefaultIocStoreConfig) saTifSourceConfig.getIocStoreConfig()).getIocToIndexDetails().add(iocToIndexDetails);
}
});

stepListener.onResponse(null);
}, e-> {
log.error("Failed to initialize the IOC index and save the IOCs", e);
baseListener.onFailure(e);
stepListener.onFailure(e);

Check warning on line 228 in src/main/java/org/opensearch/securityanalytics/services/STIX2IOCFeedStore.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/org/opensearch/securityanalytics/services/STIX2IOCFeedStore.java#L228

Added line #L228 was not covered by tests
}
));
}
Expand All @@ -237,6 +245,8 @@ private void initFeedIndex(String feedIndexName, ActionListener<CreateIndexRespo
listener.onFailure(e);
}
));
} else {
listener.onResponse(null);

Check warning on line 249 in src/main/java/org/opensearch/securityanalytics/services/STIX2IOCFeedStore.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/org/opensearch/securityanalytics/services/STIX2IOCFeedStore.java#L249

Added line #L249 was not covered by tests
}
}
}
Expand Down

0 comments on commit c238362

Please sign in to comment.