Add clarification footnote to exact search k-NN blog post #3463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Bogan <[email protected]>
ryanbogan
requested review from
elfisher,
AMoo-Miki,
nknize,
krisfreedain,
peterzhuamazon,
CEHENKLE,
dtaivpp,
kolchfa-aws,
nateynateynate and
natebower
as code owners
kolchfa-aws
previously approved these changes
Nov 25, 2024
Signed-off-by: kolchfa-aws <[email protected]>
|
@pajuric @krisfreedain @nateynateynate This is ready to merge/publish. Thanks! |
|
I'm actually going to push one more change quickly to just have the setting be |
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates a recent blog post for boosting exact search k-NN performance. A footnote is added to specify the recommended settings for users to achieve the best performance and be able to replicate the benchmarking results
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.