-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing xcontent imports #410
Conversation
Signed-off-by: Khushboo Rajput <[email protected]>
Some UTs failing? |
import org.opensearch.common.xcontent.XContentHelper; | ||
import org.opensearch.common.xcontent.XContentType; | ||
import org.opensearch.core.xcontent.XContentBuilder; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only XContentBuilder moved to core
and not the others in common
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the commit in core, the current initiative is to only move the xcontent base classes to common, see more detail at opensearch-project/OpenSearch@cb402cb
Signed-off-by: Khushboo Rajput <[email protected]>
Thank you for pointing this out, fixed the failing UTs. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #410 +/- ##
============================================
+ Coverage 70.88% 71.04% +0.15%
- Complexity 377 378 +1
============================================
Files 44 44
Lines 2597 2597
Branches 176 176
============================================
+ Hits 1841 1845 +4
+ Misses 647 644 -3
+ Partials 109 108 -1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Fixing the xcontent imports to handle the OpenSearch core refactoring change for XContent
Issue: #406
Describe the solution you are proposing
Fixing the XContent Import in code for 2.x
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.