Update jest-cli to 29.7.0 #1094
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Romero <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
joshuarrrr
requested review from
seanneumann,
AMoo-Miki,
rednaksi91,
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc,
andreymyssak and
SergeyMyssak
as code owners
BSFishy
reviewed
Oct 16, 2023
| @@ -117,7 +117,7 @@ describe('OuiCodeEditor', () => { | |||
| expect(blurSpy).toHaveBeenCalled(); | |||
| }); | |||
|
|
|||
| test('pressing escape in ace textbox will enable overlay', () => { | |||
| test.skip('pressing escape in ace textbox will enable overlay', () => { | |||
There was a problem hiding this comment.
We should make a followup issue if we decide to merge this without unskipping these
|
|
||
| jest.spyOn(colorPickerAnchor, 'focus'); | ||
|
|
||
| expect(colorPickerAnchor.focus).not.toHaveBeenCalled(); |
There was a problem hiding this comment.
Why do we check if it hasn't been called before doing anything?
| thumbs.first().simulate('keydown', { | ||
| key: keys.ARROW_DOWN, | ||
| }); | ||
| expect(thumbs.at(1).getDOMNode()).toEqual(document.activeElement); | ||
|
|
||
| expect(thumbs0.focus).toHaveBeenCalledTimes(1); |
There was a problem hiding this comment.
Is it possible to reset call count before the key down?
| @@ -580,16 +580,16 @@ describe('OuiDataGrid', () => { | |||
| return props; | |||
| }) | |||
| ).toMatchInlineSnapshot(` | |||
There was a problem hiding this comment.
We should make a good first issue to remove inline snapshots
| }); | ||
|
|
||
| it('should not call fn immediately', async () => { | ||
| const instance = new AsyncInterval(spy, 1000); |
There was a problem hiding this comment.
Why do we need to do this in each test instead of in the beforeEach?
| @@ -58,7 +58,8 @@ describe('OuiErrorBoundary', () => { | |||
|
|
|||
| test('is rendered with an error', () => { | |||
| // Prevent the React boundary error from appearing in the terminal. | |||
| spyOn(console, 'error'); // eslint-disable-line no-undef | |||
| @@ -25,7 +25,6 @@ exports[`OuiToolTip shows tooltip on focus 1`] = ` | |||
| class="ouiToolTipAnchor" | |||
| > | |||
| <button | |||
| aria-describedby="id" | |||
There was a problem hiding this comment.
It makes sense that this was deleted, but why?
7 tasks
|
Setting to draft in favor of #1102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Fixes #630
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.