Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Flint index metadata #70

Merged
merged 18 commits into from
Oct 17, 2023

Conversation

dai-chen
Copy link
Collaborator

@dai-chen dai-chen commented Oct 11, 2023

Description

  1. Refactor FlintMetadata with specific strong typed field instead of previous generic content string. (recreate the class in Scala for readability)
  2. Make use of existing XContent lib without adding extra JSON dependency to flint-core for now.
  3. Remove all JSON parsing and building logic in flint-spark-integration module.

Questions

  1. In ca44449, I missed the changes in FlintJob however all CI passed. sbt integtest/test seems passed even local sbt test failed.
  2. Meanwhile the use of FlintMetadata in FlintJob may need more UT/IT to cover.

cc: @kaituo

Issues Resolved

#24

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dai-chen dai-chen added the maintenance Code refactoring label Oct 11, 2023
@dai-chen dai-chen self-assigned this Oct 11, 2023
@dai-chen dai-chen marked this pull request as ready for review October 13, 2023 17:02
@dai-chen dai-chen merged commit b4f0a81 into opensearch-project:main Oct 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants