Translate Eval Command #499
Conversation
Signed-off-by: Lantao Jin <[email protected]>
| public class Field extends UnresolvedExpression { | ||
| private final UnresolvedExpression field; | ||
| private final QualifiedName field; |
There was a problem hiding this comment.
are we always assuming the field will be a QualifiedName ?
are there cases it wont be able to resolve ?
There was a problem hiding this comment.
Yes. This ensured by PPL syntax. https://github.com/opensearch-project/opensearch-spark/blob/main/ppl-spark-integration/src/main/antlr4/OpenSearchPPLParser.g4#L333
| @@ -172,20 +172,6 @@ public UnresolvedExpression visitPercentileAggFunction(OpenSearchPPLParser.Perce | |||
| Collections.singletonList(new Argument("rank", (Literal) visit(ctx.value)))); | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
It was removed in other PR which merged in main branch already. Since I started this work for a while so the code base in this PR has out of date I guess. So I manually removed this in my code base to avoid compile failure. Will merge main branch later.
There was a problem hiding this comment.
After merging with main branch, this git diff is gone.
Signed-off-by: Lantao Jin <[email protected]>
LantaoJin
requested review from
dai-chen,
rupal-bq,
vamsimanohar,
penghuo,
seankao-az,
anirudha and
kaituo
as code owners
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-spark/backport-0.5 0.5
# Navigate to the new working tree
pushd ../.worktrees/opensearch-spark/backport-0.5
# Create a new branch
git switch --create backport/backport-499-to-0.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 24d3b81356a5dbbbfb3a22e43375c8dbc0aaf428
# Push it to GitHub
git push --set-upstream origin backport/backport-499-to-0.5
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-spark/backport-0.5Then, create a pull request where the |
Description
This PR translates the PPL
evalcommand to Spark LogicalPlan by adding a Project with Alias expressions.Issues Resolved
Resolves #429
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.