Remove support for DataType alias

Signed-off-by: Heng Qian <[email protected]>

docs/ppl-lang/PPL-Example-Commands.md

@@ -490,8 +490,8 @@ _- **Limitation: another command usage of (relation) subquery is in `appendcols`
 #### **Cast**
 [See additional command details](functions/ppl-conversion.md)
 -  `source = table | eval int_to_string = cast(1 as string) | fields int_to_string`
--  `source = table | eval int_to_string = cast(int_col as string) | fields int_col, int_to_string`
+-  `source = table | eval int_to_string = cast(int_col as string), string_to_int = cast(string_col as integer) | fields int_to_string, string_to_int`
 -  `source = table | eval cdate = CAST('2012-08-07' as date), ctime = cast('2012-08-07T08:07:06' as timestamp) | fields cdate, ctime`
--  `source = table | eval chained_cast = cast(cast("true" as boolean) as int) | fields chained_cast`
+-  `source = table | eval chained_cast = cast(cast("true" as boolean) as integer) | fields chained_cast`
 
 ---

docs/ppl-lang/functions/ppl-conversion.md

@@ -23,10 +23,7 @@
 | TIME       | Note1  | N/A    | N/A     | N/A         | N/A    |
 +------------+--------+--------+---------+-------------+--------+
 ```
-- `NUMBER` includes `INTEGER` (alias `INT`), `LONG`, `FLOAT`, `DOUBLE`.
-
-- `BOOLEAN` has the alias `BOOL`.
-
+- `NUMBER` includes `INTEGER`, `LONG`, `FLOAT`, `DOUBLE`.
 
 Cast to **string** example:
 
@@ -40,7 +37,7 @@ Cast to **string** example:
 
 Cast to **number** example:
 
-    os> source=people | eval `cbool` = CAST(true as int), `cstring` = CAST('1' as int) | fields `cbool`, `cstring`
+    os> source=people | eval `cbool` = CAST(true as integer), `cstring` = CAST('1' as integer) | fields `cbool`, `cstring`
     fetched rows / total rows = 1/1
     +---------+-----------+
     | cbool   | cstring   |

integ-test/src/integration/scala/org/opensearch/flint/spark/ppl/FlintSparkPPLCastITSuite.scala

@@ -59,7 +59,7 @@ class FlintSparkPPLCastITSuite
   test("test cast string to compatible data types") {
     val frame = sql(s"""
                        | source=$testTable | eval
-                       | id_int = cast(cast(id as string) as int),
+                       | id_int = cast(cast(id as string) as integer),
                        | cast_true = cast("True" as boolean),
                        | cast_false = cast("false" as boolean),
                        | cast_timestamp = cast("2024-11-26 23:39:06" as timestamp),

ppl-spark-integration/src/main/java/org/opensearch/sql/ast/expression/DataType.java

@@ -32,15 +32,6 @@ public enum DataType {
   @Getter private final  ExprCoreType coreType;
 
   public static DataType fromString(String name) {
-    String upperName = name.toUpperCase();
-    // Cover some dataType alias
-    switch (upperName) {
-      case "INT":
-        return INTEGER;
-      case "BOOL":
-        return BOOLEAN;
-      default:
-        return valueOf(upperName);
-    }
+    return valueOf(name.toUpperCase());
   }
 }

ppl-spark-integration/src/test/scala/org/opensearch/flint/spark/ppl/PPLLogicalPlanCastTestSuite.scala

@@ -49,28 +49,6 @@ class PPLLogicalPlanCastTestSuite
     comparePlans(expectedPlan, logPlan2, false)
   }
 
-  test("test cast with alias") {
-    val table = UnresolvedRelation(Seq("t"))
-    val expectedPlan = Project(
-      seq(UnresolvedStar(None)),
-      Project(
-        seq(UnresolvedStar(None), Alias(Cast(UnresolvedAttribute("a"), IntegerType), "a")()),
-        table))
-
-    val context = new CatalystPlanContext
-    val logPlan =
-      planTransformer.visit(
-        plan(pplParser, """source=t | eval a = cast(a as integer)"""),
-        context)
-    comparePlans(expectedPlan, logPlan, false)
-
-    // test dataType alias
-    val context2 = new CatalystPlanContext
-    val logPlan2 =
-      planTransformer.visit(plan(pplParser, """source=t | eval a = cast(a as int)"""), context2)
-    comparePlans(expectedPlan, logPlan2, false)
-  }
-
   test("test cast literal") {
     val table = UnresolvedRelation(Seq("t"))
     val expectedPlan = Project(
@@ -84,7 +62,7 @@ class PPLLogicalPlanCastTestSuite
     val context = new CatalystPlanContext
     val logPlan =
       planTransformer.visit(
-        plan(pplParser, """source=t | eval a = cast(cast("a" as INT) as STRING)"""),
+        plan(pplParser, """source=t | eval a = cast(cast("a" as INTEGER) as STRING)"""),
         context)
     comparePlans(expectedPlan, logPlan, false)
   }
@@ -102,7 +80,7 @@ class PPLLogicalPlanCastTestSuite
     val context = new CatalystPlanContext
     val logPlan =
       planTransformer.visit(
-        plan(pplParser, """source=t | eval a = cast(cast(a as INT) as STRING)"""),
+        plan(pplParser, """source=t | eval a = cast(cast(a as INTEGER) as STRING)"""),
         context)
     comparePlans(expectedPlan, logPlan, false)
   }