Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a support for search (search_after parameter) #859

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

nathaliellenaa
Copy link
Contributor

@nathaliellenaa nathaliellenaa commented Nov 29, 2024

Description

Added sync and async sample that uses search_after parameter for #337.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.45%. Comparing base (ba715b9) to head (08bfab8).
Report is 77 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #859      +/-   ##
==========================================
- Coverage   71.95%   70.45%   -1.50%     
==========================================
  Files          91      125      +34     
  Lines        8001     9311    +1310     
==========================================
+ Hits         5757     6560     +803     
- Misses       2244     2751     +507     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like an aws sample, so let's put it into a samples/search folder. It would be good to have a _sync and an _async sample, too.

@dblock
Copy link
Member

dblock commented Nov 29, 2024

One more thing. Maybe we can write a sample that inserts many records and paginates through N pages instead until there are no more results? That seems more useful than a synthetic example with just 3 values.

… and _sync sample, and added _async sample.

Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
@dblock dblock merged commit 87aebcd into opensearch-project:main Dec 2, 2024
32 of 33 checks passed
@nathaliellenaa nathaliellenaa deleted the feature-337 branch December 3, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants