Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tests for Search Pipeline and Notifications Plugin #668

Merged
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions test_opensearchpy/test_client/test_search_pipeline.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
# SPDX-License-Identifier: Apache-2.0
#
# The OpenSearch Contributors require contributions made to
# this file be licensed under the Apache-2.0 license or a
# compatible open source license.
#
# Modifications Copyright OpenSearch Contributors. See
# GitHub history for details.

from test_opensearchpy.test_cases import OpenSearchTestCase


class TestSearchPipeline(OpenSearchTestCase):
def test_create_search_pipeline(self) -> None:
body = {
"request_processors": [
{
"filter_query": {
"tag": "tag1",
"description": "This processor returns only publicly visible documents",
"query": {"term": {"visibility": "public"}},
}
}
],
"response_processors": [
{"rename_field": {"field": "message", "target_field": "notification"}}
],
}

self.client.search_pipeline.put("my_pipeline", body)
self.assert_url_called("PUT", "/_search/pipeline/my_pipeline")

def test_get_search_pipeline(self) -> None:
self.client.search_pipeline.get("my_pipeline")
self.assert_url_called("GET", "/_search/pipeline/my_pipeline")
67 changes: 67 additions & 0 deletions test_opensearchpy/test_server/test_plugins/test_notification.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
# SPDX-License-Identifier: Apache-2.0
#
# The OpenSearch Contributors require contributions made to
# this file be licensed under the Apache-2.0 license or a
# compatible open source license.
#
# Modifications Copyright OpenSearch Contributors. See
# GitHub history for details.


from __future__ import unicode_literals

from .. import OpenSearchTestCase


class TestNotificationPlugin(OpenSearchTestCase):
async def test_create_channel_notification(self) -> None:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • @AbitraryYu, please remove async from all the test cases in this file.
  • After removing async, you might notice that some test cases fail. Please fix them.
  • For example, test_delete_channel_configuration may fail. Remember, each test case is isolated, so create the configuration before deleting it within the same test case. See this reference. Thank you.

content = {
"config_id": "sample-id",
"name": "sample-name",
"config": {
"name": "Sample Slack Channel",
"description": "This ialerting.create_destination(dummy_destination)s a Slack channel",
"config_type": "slack",
"is_enabled": True,
"slack": {"url": "https://sample-slack-webhook"},
},
}
response = self.client.plugins.notifications.create_config(content)

self.assertNotIn("errors", response)
self.assertIn("config_id", response)

async def test_list_all_channel_configurations(self) -> None:
response = self.client.plugins.notifications.list_features()

self.assertNotIn("errors", response)
self.assertIn("config_id", response)

async def test_list_all_notification_configurations(self) -> None:
response = self.client.plugins.notifications.get_config()

self.assertNotIn("errors", response)
self.assertIn("config_id", response)

async def test_get_channel_configuration(self) -> None:
response = self.client.plugins.notifications.get_config(config_id="sample-id")

self.assertNotIn("errors", response)
self.assertIn("config_id", response)

async def test_update_channel_configuration(self) -> None:
response = self.client.plugins.notifications.update_config(
config_id="sample-id"
)

self.assertNotIn("errors", response)
self.assertIn("config_id", response)

async def test_delete_channel_configuration(self) -> None:
# Try fetching the destination
response = self.client.plugins.notifications.delete_config(
config_id="sample-id"
)

self.assertNotIn("errors", response)
self.assertIn("config_id", response)
Loading