Update the GHA release workflow with trusted publisher enabled #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zelin Hao <[email protected]>
Signed-off-by: Zelin Hao <[email protected]>
zelinh
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor,
Shephalimittal,
saimedhi and
florianvazelle
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
=======================================
Coverage 71.98% 71.98%
=======================================
Files 89 89
Lines 7935 7935
=======================================
Hits 5712 5712
Misses 2223 2223 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Zelin Hao <[email protected]>
Signed-off-by: Zelin Hao <[email protected]>
dblock
requested changes
Nov 23, 2023
CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| - Added pylint `line-too-long` and `invalid-name` ([#590](https://github.com/opensearch-project/opensearch-py/pull/590)) | |||
| - Added pylint `pointless-statement` ([#611](https://github.com/opensearch-project/opensearch-py/pull/611)) | |||
| - Added a log collection guide ([#579](https://github.com/opensearch-project/opensearch-py/pull/579)) | |||
| - - Update the GHA release workflow with trusted publisher enabled ([#614](https://github.com/opensearch-project/opensearch-py/pull/614)) | |||
CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| - Added pylint `line-too-long` and `invalid-name` ([#590](https://github.com/opensearch-project/opensearch-py/pull/590)) | |||
| - Added pylint `pointless-statement` ([#611](https://github.com/opensearch-project/opensearch-py/pull/611)) | |||
| - Added a log collection guide ([#579](https://github.com/opensearch-project/opensearch-py/pull/579)) | |||
| - - Update the GHA release workflow with trusted publisher enabled ([#614](https://github.com/opensearch-project/opensearch-py/pull/614)) | |||
There was a problem hiding this comment.
Updated here. Please help review it again. Thanks.
Signed-off-by: Zelin Hao <[email protected]>
dblock
approved these changes
Nov 23, 2023
|
Btw, we noticed #609 related to publishing to pypi. Maybe you know how to fix it ... |
|
OIDC on Pypi side for trusted publisher is added. |
roma2023
pushed a commit
to roma2023/opensearch-py
that referenced
this pull request
Dec 28, 2023
…earch-project#614) * Add GitHub action for opensearch-py release Signed-off-by: Zelin Hao <[email protected]> * Generate GitHub release at the end Signed-off-by: Zelin Hao <[email protected]> * Update CHANGELOG Signed-off-by: Zelin Hao <[email protected]> * Update CHANGELOG Signed-off-by: Zelin Hao <[email protected]> --------- Signed-off-by: Zelin Hao <[email protected]> Signed-off-by: roma2023 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable GHA release by adding trusted publisher.
This workflow will be triggered when a tag is pushed to this repository. The workflow will built the product and publish to Pypi.
The GitHub release will be created after publishing to Pypi with
artifacts.tar.gz.I will add this workflow as trusted publisher according to this. https://docs.pypi.org/trusted-publishers/adding-a-publisher/
Issues Resolved
Part of opensearch-project/opensearch-build-libraries#222
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.