Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: TypeError on calling parallel_bulk. #601

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

dblock
Copy link
Member

@dblock dblock commented Nov 17, 2023

Description

Fix: TypeError on calling parallel_bulk.

Issues Resolved

Closes #599

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (567ede3) 71.86% compared to head (b3da091) 71.97%.

❗ Current head b3da091 differs from pull request most recent head 331c684. Consider uploading reports for the commit 331c684 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
+ Coverage   71.86%   71.97%   +0.11%     
==========================================
  Files          89       89              
  Lines        7932     7932              
==========================================
+ Hits         5700     5709       +9     
+ Misses       2232     2223       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock dblock marked this pull request as ready for review November 17, 2023 14:28
@harshavamsi
Copy link
Collaborator

@dblock do you think #600 is related? I see some bulk related operations there

Copy link
Collaborator

@harshavamsi harshavamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I am not too familiar with helpers code, but bulk and parallel bulk with options looks good.

@VachaShah VachaShah merged commit c66e1e3 into opensearch-project:main Nov 17, 2023
54 checks passed
@dblock
Copy link
Member Author

dblock commented Nov 17, 2023

@dblock do you think #600 is related? I see some bulk related operations there

Nope.

@dblock dblock deleted the fix-599 branch November 17, 2023 20:01
roma2023 pushed a commit to roma2023/opensearch-py that referenced this pull request Dec 28, 2023
* Fix: TypeError on calling parallel_bulk.

Signed-off-by: dblock <[email protected]>

* Added a sample that uses a bulk function generator.

Signed-off-by: dblock <[email protected]>

---------

Signed-off-by: dblock <[email protected]>
Signed-off-by: roma2023 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] TypeError on calling parallel_bulk (v2.4.0)
3 participants